core icon indicating copy to clipboard operation
core copied to clipboard

Add snapshot service to image entity

Open NickM-27 opened this issue 1 year ago • 1 comments

Proposed change

Integrations are moving from using the camera.entity to image.entity but there is not feature parity when it comes to the services offered for the image.entity. This PR adds the snapshot service to the image entity so users are able to save the images offline for their own usage.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/31327

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

NickM-27 avatar Feb 08 '24 21:02 NickM-27

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (image) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of image can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign image Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Feb 08 '24 21:02 home-assistant[bot]

@NickM-27 There are merge conflicts, can you please merge or rebase the PR?

emontnemery avatar Feb 29 '24 10:02 emontnemery

@emontnemery thanks, rebased 👍

NickM-27 avatar Feb 29 '24 13:02 NickM-27

looks like the failing tests are unrelated to these changes

NickM-27 avatar Apr 11 '24 14:04 NickM-27

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Apr 21 '24 03:04 home-assistant[bot]

Hello, is this going to land in 2024.7? I would like to see, who is at the door again, after several months ;)

Elkropac avatar Jun 24 '24 20:06 Elkropac

Is this close to being updated/merged?

kevinahuber avatar Aug 12 '24 21:08 kevinahuber