core icon indicating copy to clipboard operation
core copied to clipboard

RadioRA2 Unnamed entities

Open MarkzP opened this issue 1 year ago • 43 comments

The problem

Entity ids for lights, occupancy & some switches are no longer matching Lutron integration names: previously these were formatted as light.[area].[name]. Since 2024.2.0 the entity ids of the same lights are now light.unnamed_device_xx, breaking automations. Entity names are similarly affected; Not sure if this is intended or not

What version of Home Assistant Core has the issue?

2024.2.0

What was the last working version of Home Assistant Core?

2024.1.0

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Lutron

Link to integration documentation on our website

https://www.home-assistant.io/integrations/lutron

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

MarkzP avatar Feb 08 '24 17:02 MarkzP

Hey there @cdheiser, @wilburcforce, mind taking a look at this issue as it has been labeled with an integration (lutron) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lutron can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign lutron Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


lutron documentation lutron source (message by IssueLinks)

home-assistant[bot] avatar Feb 08 '24 17:02 home-assistant[bot]

I believe the previous naming was entityType.[area]_[name] I don't think this was intentional and I have not seen that happen in my instance. My entities all remained the same. @joostlek did the work to create devices which I think might have introduced this. There is some tie in to the device naming in the current architecture. @joostlek can you comment on expected behavior? It appears that the entity no longer specifies a name. The doc seems to indicate that when an entity is the sole purpose of the device that it wouldn't specify a name. Thoughts?

wilburCforce avatar Feb 08 '24 18:02 wilburCforce

I can also confirm that I'm not seeing this happen in my instance.

On Thu, Feb 8, 2024 at 10:05 AM wilburCforce @.***> wrote:

I believe the previous naming was entityType.[area]_[name] I don't think this was intentional and I have not seen that happen in my instance. My entities all remained the same. @joostlek https://github.com/joostlek did the work to create devices which I think might have introduced this. There is some tie in to the device naming in the current architecture. @joostlek https://github.com/joostlek can you comment on expected behavior? It appears that the entity no longer specifies a name. The doc seems to indicate that when an entity is the sole purpose of the device that it wouldn't specify a name. Thoughts?

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/110038#issuecomment-1934673028, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQARWVP3ZP425YI7RWHHO3YSUHU7AVCNFSM6AAAAABDAEXUJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUGY3TGMBSHA . You are receiving this because you were mentioned.Message ID: @.***>

cdheiser avatar Feb 08 '24 18:02 cdheiser

It should not break automations iirc, since the unique id didn't change. If it did, I don't know what exactly happened.

I think it's strange that the device has no name. Since Wilber can't reproduce it, can @cdheiser send me a message on discord? (You should already have a PM request) and we can try to figure stuff out

joostlek avatar Feb 08 '24 18:02 joostlek

@MarkzP it might also be helpful to have some examples from your entity registry which is located in config/.storage/core.entity_registry The unique_id attribute should be a value of [main repeater guid]_[uuid from xml] Assuming the data matches up to your xml file it should have kept the same name. If there was something different in your entity registry before then it would not have matched and I think you would have gotten new entities.

wilburCforce avatar Feb 08 '24 18:02 wilburCforce

Turns out my RA2 firmware is fairly old, so no device UUID = no entity unique ids = no entities created in the registry

Looks like this suggestion would be very helpful in my case I no longer have access to the original integration files, so to update the firmware I would have to reprogram the system from scratch, which is something I'm trying to avoid as much as I can

Thanks for your help!

MarkzP avatar Feb 08 '24 22:02 MarkzP

On Thu, Feb 8, 2024 at 2:26 PM Marc Paquette @.***> wrote:

Turns out my RA2 firmware is fairly old, so no device UUID = no entity unique ids = no entities created in the registry

Looks like this suggestion https://github.com/thecynic/pylutron/issues/70#issuecomment-932869066 would be very helpful in my case I no longer have access to the original integration files, so to update the firmware I would have to reprogram the system from scratch, which is something I'm trying to avoid as much as I can

You don't need the original integration files. The RadioRA programming software can extract the current programing from the main repeater.

Thanks for your help!

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/110038#issuecomment-1935032181, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQARWUN55XAWK6M65KEEVLYSVGLFAVCNFSM6AAAAABDAEXUJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZVGAZTEMJYGE . You are receiving this because you were mentioned.Message ID: @.***>

cdheiser avatar Feb 08 '24 22:02 cdheiser

I believe the previous naming was entityType.[area]_[name] I don't think this was intentional and I have not seen that happen in my instance. My entities all remained the same. @joostlek did the work to create devices which I think might have introduced this. There is some tie in to the device naming in the current architecture. @joostlek can you comment on expected behavior? It appears that the entity no longer specifies a name. The doc seems to indicate that when an entity is the sole purpose of the device that it wouldn't specify a name. Thoughts?

This only happens when you re-initialize the integration. Mine were fine, but I made major updates with phantom keypads and needed to clear out the registry to fix some hanging issues. Upon doing so, it picked up the new naming convention and stopped prefixing with _area/zone_name

BWilky avatar Feb 08 '24 23:02 BWilky

Reverted back to 24.1.5 confirming works without issue with previous naming convention

BWilky avatar Feb 09 '24 02:02 BWilky

I had the same issue. Entity names were previously "[area] [device name]" (generally auto-created by the integration) and after upgrading to 2024.2.0 and removing the lutron section from configuration.py, my devices lost the area name.

I just finished renaming 100+ entitites, and after doing so, many of them still had the word "none" appended to the name in various dashboards. For example, Lutron area "Zach's room," device "closet light" appeared as "closet light" in the entity configuration post-2024.2.0. In the dashboard, this appeared as "closet light None." After manually renaming to "Zach's room closet light," it appeared in the dashboard as "Zach's room closet light None."

My RadioRa2 main repeater firmware is current/latest.

jmayzurk avatar Feb 09 '24 02:02 jmayzurk

Please take note that with the new naming (which is used in 400+ other integrations) you can rename devices and automatically rename all entities.

The fact that the word None is appended is strange, can you maybe open a separate issue?

joostlek avatar Feb 09 '24 09:02 joostlek

I had the same issue. Entity names were previously "[area] [device name]" (generally auto-created by the integration) and after upgrading to 2024.2.0 and removing the lutron section from configuration.py, my devices lost the area name.

I just finished renaming 100+ entitites, and after doing so, many of them still had the word "none" appended to the name in various dashboards. For example, Lutron area "Zach's room," device "closet light" appeared as "closet light" in the entity configuration post-2024.2.0. In the dashboard, this appeared as "closet light None." After manually renaming to "Zach's room closet light," it appeared in the dashboard as "Zach's room closet light None."

My RadioRa2 main repeater firmware is current/latest.

How did you rename these entities? They appear as read only and can’t be renamed.

eleibzon avatar Feb 09 '24 21:02 eleibzon

Restored back to 2024.1.6 and all the names show up. Hope this bug will be fixed soon.

eleibzon avatar Feb 10 '24 07:02 eleibzon

Same problem here. I only have 4 shades in my RadioRa2, and now they all show up as Unnamed device: Screenshot 2024-02-10 at 15 17 38

My firmware is probably also quite old, but I can't upgrade because from what I understand, newer firmwares requires a Lutron installer account to program 🙄

There is no mention of the shades in config/.storage/core.entity_registry

Each of my 4 shades does have a uniq id in the attribute though: "Lutron integration ID 10" (and 7, 11 and 12)

Renaming is also not possible because: Screenshot 2024-02-10 at 15 24 16

Please let me know if there is anything I can help with (all though I'm not at programmer).

On an unrelated note. I have long gotten a lot of these in the log:

2024-02-10 15:25:38.962 ERROR (Thread-4) [pylutron] Uncaught exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/pylutron/__init__.py", line 178, in _main_loop
    line = t.read_until(b"\n", timeout=3)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/telnetlib.py", line 320, in read_until
    self.fill_rawq()
  File "/usr/local/lib/python3.12/telnetlib.py", line 528, in fill_rawq
    buf = self.sock.recv(50)
          ^^^^^^^^^^^^^^^^^^
TimeoutError: [Errno 110] Operation timed out
2024-02-10 15:25:38.964 WARNING (Thread-4) [pylutron] Disconnected

Apparently not causing any problems, but upon investigating it I stumbled upon the obsoletion of telnetlib.py: https://docs.python.org/3/library/telnetlib.html

Deprecated since version 3.11, will be removed in version 3.13: The [telnetlib]> (https://docs.python.org/3/library/telnetlib.html#module-telnetlib) module is deprecated (see [PEP 594]> (https://peps.python.org/pep-0594/#telnetlib) for details and alternatives).

MortenVinding avatar Feb 10 '24 14:02 MortenVinding

I am also seeing the "unnamed_device" issue with the lights on my QS . Prior to 2024.2 my Lutron entities were named using the area and name that is stored with Lutron QS controller, and the integration_id was available as an attribute. I can make debug logs available for startups of 2024.1 and 2024.2, if that helps.

awrede avatar Feb 10 '24 19:02 awrede

Just confirming seeing the exact same issues as the OP, and rolling back to 2024.1.5 restored it for me. I unfortunately don't have access to the RadioRA2 Inclusive software, which is required as a I have two repeaters in my setup, so hoping this can be fixed with needing to do any trickery using that software.

kbed72 avatar Feb 10 '24 19:02 kbed72

If someone can post a dhinfoxml from their system that's experiencing this problem it would help in debugging

On Sat, Feb 10, 2024, 11:56 AM kbed72 @.***> wrote:

Just confirming seeing the exact same issues as the OP, and rolling back to 2024.1.5 restored it for me. I unfortunately don't have access to the RadioRA2 Inclusive software, which is required as a I have two repeaters in my setup, so hoping this can be fixed with needing to do any trickery using that software.

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/110038#issuecomment-1937107149, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQARWWPZDV2SFMKBR632GLYS7GGHAVCNFSM6AAAAABDAEXUJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXGEYDOMJUHE . You are receiving this because you were mentioned.Message ID: @.***>

cdheiser avatar Feb 10 '24 22:02 cdheiser

DbXmlInfo.zip

Adding my config.

kbed72 avatar Feb 10 '24 23:02 kbed72

DbXmlInfo.zip

Here is mine

awrede avatar Feb 11 '24 02:02 awrede

Just confirming seeing the exact same issues as the OP, and rolling back to 2024.1.5 restored it for me. I unfortunately don't have access to the RadioRA2 Inclusive software, which is required as a I have two repeaters in my setup, so hoping this can be fixed with needing to do any trickery using that software.

https://www.reddit.com/r/Lutron/comments/12ctcgv/psa_lutron_now_allows_homeowners_to_do_radiora2/?share_id=T7Y3kN1mYq-H-vNoNH47E&utm_content=1&utm_medium=ios_app&utm_name=ioscss&utm_source=share&utm_term=1

Still works, scroll down to bottom of curl response. Literally just upgraded

BWilky avatar Feb 11 '24 03:02 BWilky

Note I have created https://github.com/thecynic/pylutron/pull/90 to add support for UUIDs when they're missing in the XML.

I don't know if this will fix the issues mentioned here as it's a bit more difficult to reproduce without a system with old firmware as we haven't exactly broken this up well for good unit tests.

On Sat, Feb 10, 2024 at 7:57 PM BWilky @.***> wrote:

Just confirming seeing the exact same issues as the OP, and rolling back to 2024.1.5 restored it for me. I unfortunately don't have access to the RadioRA2 Inclusive software, which is required as a I have two repeaters in my setup, so hoping this can be fixed with needing to do any trickery using that software.

https://www.reddit.com/r/Lutron/comments/12ctcgv/psa_lutron_now_allows_homeowners_to_do_radiora2/?share_id=T7Y3kN1mYq-H-vNoNH47E&utm_content=1&utm_medium=ios_app&utm_name=ioscss&utm_source=share&utm_term=1

Still works, scroll down to bottom of curl response. Literally just upgraded

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/110038#issuecomment-1937414516, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQARWQPHCQM5JLGEJWBLDLYTA6RPAVCNFSM6AAAAABDAEXUJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXGQYTINJRGY . You are receiving this because you were mentioned.Message ID: @.***>

cdheiser avatar Feb 11 '24 06:02 cdheiser

Wanted to provide an update on my end. Following the post that @BWilky provided, I was able to install and register RadioRa2 Inclusive and upgrade my Main Repeater firmware to the latest version. I rolled forward to the latest version of HA to see if the firmware upgrade solved the issue with entities being named wrong... and tadaaa, it did! I can confirm the issue is resolve with the firmware upgrade.

kbed72 avatar Feb 13 '24 01:02 kbed72

In the interim, for people that don't want to or cannot upgrade their firmware, there's been work on a fix. The underlying pylutron library now provides legacy_uuids in addition to the uuids from the XML (if present). This will allow the lutron component to use a legacy uuid if the firmware is old, as well as migrate entities if you upgrade later.

On Mon, Feb 12, 2024 at 5:52 PM kbed72 @.***> wrote:

Wanted to provide an update on my end. Following the post that @BWilky https://github.com/BWilky provided, I was able to install and register RadioRa2 Inclusive and upgrade my Main Repeater firmware to the latest version. I rolled forward to the latest version of HA to see if the firmware upgrade solved the issue with entities being named wrong... and tadaaa, it did! I can confirm the issue is resolve with the firmware upgrade.

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/110038#issuecomment-1940182886, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQARWVVJSKIFAN3BEULJEDYTLBM7AVCNFSM6AAAAABDAEXUJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBQGE4DEOBYGY . You are receiving this because you were mentioned.Message ID: @.***>

cdheiser avatar Feb 13 '24 06:02 cdheiser

I've put together a fix for the UUID issue. Unfortunately, returning to the old naming of entities does not look like it is possible with the introduction of the devices. Entity naming follows the device name and if you add the area_device to the entity name the resultant friendly name also incorporates the device name. So you end up with device_area_device which is a mess. If we change the device name to area_device then you have a lot of garbage data since the area is a separate attribute on a device. So I think we just need to move into the future for this part of it.

The PR noted above will address the uuid with the legacy uuid cdheiser added in pylutron 2.12. If you update your firmware to a later version it will update the identifiers as well to make the transition seamless. For users that already have naming in place, this change won't result in any changes. It comes into play when you add the integration fresh.

For users that rolled back to 2024.1, you will still end up with new entities once this is implemented but the naming will be correct and that should be the last time you have this happen. There's just no clean way to update and identify these otherwise at this point.

wilburCforce avatar Feb 14 '24 15:02 wilburCforce

I have tried to implement the fix by creating a custom integration and placing all files from https://github.com/home-assistant/core/tree/dev/homeassistant/components/lutron in lutron folder.

After restart I get the following error in the logs:

The custom integration 'lutron' does not have a version key in the manifest file and was blocked from loading. See https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions for more details

any ideas much appreciated.

eleibzon avatar Feb 20 '24 11:02 eleibzon

I have tried to implement the fix by creating a custom integration and placing all files from https://github.com/home-assistant/core/tree/dev/homeassistant/components/lutron in lutron folder.

After restart I get the following error in the logs:

The custom integration 'lutron' does not have a version key in the manifest file and was blocked from loading. See https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions for more details

any ideas much appreciated.

The update to pylutron 2.12 to support this issue was delivered in 2024.2.2. The corresponding fix in Home Assistant noted above ( https://github.com/home-assistant/core/pull/110524 ) has been accepted and merged into the dev branch and is currently tagged for release with 2024.2.3 which I would anticipate in the next week or so. Watch the release notes to see if it was included before you update.

wilburCforce avatar Feb 20 '24 21:02 wilburCforce

you need to add a version to the manifest.json like this: "version": "1.0.0"

On Tue, Feb 20, 2024 at 1:01 PM wilburCforce @.***> wrote:

I have tried to implement the fix by creating a custom integration and placing all files from https://github.com/home-assistant/core/tree/dev/homeassistant/components/lutron in lutron folder.

After restart I get the following error in the logs:

The custom integration 'lutron' does not have a version key in the manifest file and was blocked from loading. See https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions for more details

any ideas much appreciated.

The update to pylutron 2.12 to support this issue was delivered in 2024.2.2. The corresponding fix in Home Assistant noted above ( #110524 https://github.com/home-assistant/core/pull/110524 ) has been accepted and merged into the dev branch and is currently tagged for release with 2024.2.3 which I would anticipate in the next week or so. Watch the release notes to see if it was included before you update.

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/110038#issuecomment-1955090385, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQARWX76EJMXGH6SAJVBR3YUUFJDAVCNFSM6AAAAABDAEXUJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJVGA4TAMZYGU . You are receiving this because you were mentioned.Message ID: @.***>

cdheiser avatar Feb 20 '24 21:02 cdheiser

you need to add a version to the manifest.json like this: "version": "1.0.0" On Tue, Feb 20, 2024 at 1:01 PM wilburCforce @.> wrote: I have tried to implement the fix by creating a custom integration and placing all files from https://github.com/home-assistant/core/tree/dev/homeassistant/components/lutron in lutron folder. After restart I get the following error in the logs: The custom integration 'lutron' does not have a version key in the manifest file and was blocked from loading. See https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions for more details any ideas much appreciated. The update to pylutron 2.12 to support this issue was delivered in 2024.2.2. The corresponding fix in Home Assistant noted above ( #110524 <#110524> ) has been accepted and merged into the dev branch and is currently tagged for release with 2024.2.3 which I would anticipate in the next week or so. Watch the release notes to see if it was included before you update. — Reply to this email directly, view it on GitHub <#110038 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQARWX76EJMXGH6SAJVBR3YUUFJDAVCNFSM6AAAAABDAEXUJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJVGA4TAMZYGU . You are receiving this because you were mentioned.Message ID: @.>

The versions are handled by automation. That's a placeholder.

wilburCforce avatar Feb 20 '24 22:02 wilburCforce

I had the same issue. Entity names were previously "[area] [device name]" (generally auto-created by the integration) and after upgrading to 2024.2.0 and removing the lutron section from configuration.py, my devices lost the area name.

I just finished renaming 100+ entitites, and after doing so, many of them still had the word "none" appended to the name in various dashboards. For example, Lutron area "Zach's room," device "closet light" appeared as "closet light" in the entity configuration post-2024.2.0. In the dashboard, this appeared as "closet light None." After manually renaming to "Zach's room closet light," it appeared in the dashboard as "Zach's room closet light None."

My RadioRa2 main repeater firmware is current/latest.

I updated to 2024.2.2 from 2024.1.x and have this same issue with "None" being added to the end of the name in Home Assistant. If the Lutron entity is a light entity, "None" is not added. If a switch entity, "None" is added. Not sure where "None" is coming from, any suggestions?

Thanks

jschafermo avatar Feb 21 '24 20:02 jschafermo

I updated to 2024.2.2 from 2024.1.x and have this same issue with "None" being added to the end of the name in Home Assistant. If the Lutron entity is a light entity, "None" is not added. If a switch entity, "None" is added. Not sure where "None" is coming from, any suggestions?

This will be my final response to folks that don't read this issue for the answers. The fix for pylutron is in 2024.2 and the fix for the home assistant Lutron component is scheduled for 2024.3 which is not yet released. Please read the comments above for more information.

wilburCforce avatar Feb 21 '24 20:02 wilburCforce