core icon indicating copy to clipboard operation
core copied to clipboard

HomeKit Bridge integration not importing valve type devices

Open blueyetisoftware-jason opened this issue 1 year ago • 5 comments

The problem

The integration appears to support valves as a feature, but the valve device type is not available in the domain selector. It appears that the integration is assuming valves will be of domain "switch" with a type attribute of "valve", rather than being of domain "valve" themselves. I'm not sure if this is a bug or just a missing feature.

What version of Home Assistant Core has the issue?

core-2024.1.6

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

HomeKit Bridge

Link to integration documentation on our website

https://www.home-assistant.io/integrations/homekit#type

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

blueyetisoftware-jason avatar Feb 06 '24 23:02 blueyetisoftware-jason

Hey there @bdraco, mind taking a look at this issue as it has been labeled with an integration (homekit) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homekit can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign homekit Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


homekit documentation homekit source (message by IssueLinks)

home-assistant[bot] avatar Feb 06 '24 23:02 home-assistant[bot]

From memory, you can expose them using YAML as you described. The UI does not support this, I believe.

codyc1515 avatar Feb 07 '24 10:02 codyc1515

From memory, you can expose them using YAML as you described. The UI does not support this, I believe.

Yeah, I suppose my issue report is specifically about not showing "Valve" in the domain UI. I'd be surprised if it couldn't be supported through the menu UI. Those look like standard domains. If you try to bring in an actual valve, you have to create a "template switch" that mimics the valve and then specify its type as "valve" in the yaml. It's a very round-a-bout way to specify a valve as a valve.

blueyetisoftware-jason avatar Feb 07 '24 18:02 blueyetisoftware-jason

Valve was only just added is why.

codyc1515 avatar Feb 07 '24 19:02 codyc1515

Valve was only just added is why.

I'm likely into new feature territory, but I got the valve imported as a switch. In addition to the workarounds above, the other side effect is that the valve is only open or closed and doesn't indicate if there is any flow. Many valves operate in 3 states (off, on and not flowing, on and flowing). The flow is then controlled by something internal to the valve like a float switch or schedule. You also see this with sprinklers. They normally show as "waiting" when you turn them on, and then flip to a runtime when that zone begins flowing.

blueyetisoftware-jason avatar Feb 10 '24 00:02 blueyetisoftware-jason

I have the same problem. I also can't add a valve to HomeKit. I have tried adding it through I have tried adding it through edit the configuration file

homekit:
   - filter:
       include_entities:
       - valve.heating_valve_heating_relay_2

But it doesn't add it, instead if I change it for a switch it works


homekit:
   - filter:
       include_entities:
       - switch.heating_valve_heating_relay_2

bato2000 avatar Feb 10 '24 17:02 bato2000

@bdraco are you planning to add support for valves?

martindybal avatar Apr 18 '24 09:04 martindybal

Hello, even with Home Assistant 2024.7. I'm unable to add my Valves to HomeKit.

image

image

martindybal avatar Jul 03 '24 17:07 martindybal

The change isn't in 2024.7.x, its in 2024.8.x

bdraco avatar Jul 03 '24 17:07 bdraco

Oh, ok. Thank you!

martindybal avatar Jul 04 '24 12:07 martindybal