core icon indicating copy to clipboard operation
core copied to clipboard

Disable energy report based operations with API lib upgrade

Open vilppuvuorinen opened this issue 1 year ago • 1 comments

Breaking change

Proposed change

Upgrade pymelcloud to remove energy report based operations. This change breaks daily energy consumption for ATW devices, but help prevent throttling. The API lib returns always None now which is a valid return value according to the existing type annotations. See commit for details https://github.com/vilppuvuorinen/pymelcloud/commit/a4a586acb84b5f7fafa8d1dd081e7b9748172385

Type of change

  • [x] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

vilppuvuorinen avatar Feb 06 '24 20:02 vilppuvuorinen

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Feb 06 '24 21:02 home-assistant[bot]

I've taken the liberty to make the adjustments.

frenck avatar Feb 07 '24 05:02 frenck