core icon indicating copy to clipboard operation
core copied to clipboard

Add Ring Intercom support

Open cosimomeli opened this issue 1 year ago • 1 comments
trafficstars

Breaking change

Proposed change

Add Ring Intercom support as it has been enabled in the ring-doorbell library version 0.8.7. The device has a button to trigger the Open Door rpc and sensors with volume settings.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #91600
  • This PR is related to issue: #91600
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/31274

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

cosimomeli avatar Feb 06 '24 17:02 cosimomeli

Hey there @sdb9696, mind taking a look at this pull request as it has been labeled with an integration (ring) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ring can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ring Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Feb 06 '24 17:02 home-assistant[bot]

up :-p interested in addind this PR

Smandurlo avatar Mar 09 '24 11:03 Smandurlo

I'm also really looking forward to this being merged. Have been following the progress on this for months by now and can't wait to get rid of my homebridge as soon as I can use my intercom from within home assistant.

muffn avatar Mar 09 '24 11:03 muffn

Hello, Could this change be approved ? I'm following since the PR #91600 was opened. Thanks,

anongeek avatar Mar 09 '24 13:03 anongeek

Also looking this to be merged. Very interested since i moved from Homebridge to HomeAssistant to get my Intercom up and running again.

vJan00 avatar Mar 10 '24 23:03 vJan00

The open door button will be integrated in another PR, so I need now to remove the new-platform label

cosimomeli avatar Mar 14 '24 20:03 cosimomeli

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Mar 15 '24 10:03 home-assistant[bot]

Test fixed

cosimomeli avatar Mar 15 '24 11:03 cosimomeli

Many thanks @cosimomeli for all your hard work getting this over the line! :rocket:

sdb9696 avatar Mar 15 '24 17:03 sdb9696

And thank you and @joostlek for the help!

cosimomeli avatar Mar 15 '24 18:03 cosimomeli