core icon indicating copy to clipboard operation
core copied to clipboard

Bump ZHA dependencies

Open puddly opened this issue 1 year ago • 2 comments

Proposed change

Bump ZHA dependencies:

This PR fixes a bug with zigpy's handling of default responses (affecting Tuya sensors), improves reliability when communicating with Silicon Labs radios and reduces unnecessary resets, and finally fixes Conbee III compatibility issues introduced in 2024.1.6.

Type of change

  • [x] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

puddly avatar Feb 06 '24 00:02 puddly

Hey there @dmulcahey, @adminiuga, @thejulianjes, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Feb 06 '24 00:02 home-assistant[bot]

~~The SiLabs flasher dependency will need to be upgraded as well in this PR, as it depends on bellows.~~

Done.

puddly avatar Feb 06 '24 00:02 puddly

No issues noticed during a quick test (EZSP), but zha/test_update.py test_firmware_update_success seems to fail with zigpy 0.62.0 or higher for me.

TheJulianJES avatar Feb 06 '24 03:02 TheJulianJES

Looks like there is variable binding issue in the most recent zigpy release's listener matching that wasn't covered by unit tests:

2024-02-05 23:22:44.813 DEBUG    MainThread zigpy.device:manager.py:203 [0xb79c] OTA image_notify handler - exception: cannot access local variable 'match' where it is not associated with a value

Drafting until this is resolved.

puddly avatar Feb 06 '24 04:02 puddly

Issue resolved, it was just a Direction enum I missed in ZHA unit tests that needed to be flipped. In fact, the only use of Direction anywhere in ZHA.

Tests pass locally for me.

puddly avatar Feb 06 '24 13:02 puddly