core icon indicating copy to clipboard operation
core copied to clipboard

Update JVC Projector polling time to be more responsive for automations

Open msavazzi opened this issue 1 year ago • 1 comments

Breaking change

Proposed change

The current time (ON 6 sec - OFF 60 sec) is too long and it means that when powered on the automations will be invoked 1 minute after the project is on. This is bad as the warming is shorter and it can create issues with several items like powering on media players, amplifier settings, roller opening, etc. So I've changed the time to 5 / 10 sec to lower the checks on the projector when off but to be responsive enough during the power on cycle

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes # 109732
  • This PR is related to issue: https://github.com/home-assistant/core/issues/109732
  • Link to documentation pull request: not needed - no change

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

msavazzi avatar Feb 05 '24 16:02 msavazzi

Hey there @steveeasley, mind taking a look at this pull request as it has been labeled with an integration (jvc_projector) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of jvc_projector can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign jvc_projector Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Feb 05 '24 16:02 home-assistant[bot]

I wonder if this PR should be against dev and not your sensor PR. Its not clear what the change is to other reviewers. But maybe I am wrong.

SteveEasley avatar Feb 10 '24 18:02 SteveEasley

I wonder if this PR should be against dev and not your sensor PR. Its not clear what the change is to other reviewers. But maybe I am wrong.

Hem... I followed the suggestion of @joostlek and tried to create a second PR just for the FAST/SLOW change as he suggested to have it independet... but may be I've done a little of a mess :) joostlek told me that the sensor was to be merged before and then this one... so everything should be ok, am I wrong?

msavazzi avatar Feb 10 '24 18:02 msavazzi