core icon indicating copy to clipboard operation
core copied to clipboard

Update Growatt server URLs

Open chenjiayi8 opened this issue 1 year ago • 4 comments

Breaking change

Proposed change

I contacted Growatt IT department, they provide these URLs for users from different regions:

"https://openapi-cn.growatt.com/", # Chinese server "https://openapi-us.growatt.com/", # North American server "https://openapi.growatt.com/", # Other regional server: e.g. Europe

The servers are hosted in specific regions to comply with local regulations. As a result, it is not recommended to use "https://server.growatt.com/" outside of China.

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #109081, #107721, #104413, #103833, #103296
  • This PR is related to issue: growatt server url
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/31137

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

chenjiayi8 avatar Jan 30 '24 12:01 chenjiayi8

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Jan 30 '24 12:01 home-assistant[bot]

Documentary is updated in (https://github.com/home-assistant/home-assistant.io/pull/31137)

chenjiayi8 avatar Jan 30 '24 13:01 chenjiayi8

Duplicate of #107498 and many others.

Please provide extensive details and information for these changes in the PR description.

../Frenck

frenck avatar Jan 30 '24 13:01 frenck

@frenck This PR is actually well described, in contrary to the other ones that are also abandoned by its authors. Lets work to make this one be the one that finally gets reviewed and integrated.

marcovtwout avatar Feb 03 '24 19:02 marcovtwout