core icon indicating copy to clipboard operation
core copied to clipboard

Expose dynamic range status in Onkyo media player

Open Spacetech opened this issue 1 year ago • 1 comments

Proposed change

I want to create some automations based on whether or not HDR content is currently being output to my TV. The Onkyo component exposes a lot of video information, but it's unfortunately not including the dynamic range / HDR status right now.

Type of change

This change exposes a new dynamic_range property in video_information, which is parsed from the existing Onkyo eISCP data.

Example of the new dynamic_range showing up: image

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [X] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

N/A

Checklist

  • [X] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Spacetech avatar Jan 30 '24 06:01 Spacetech

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Jan 30 '24 06:01 home-assistant[bot]