core icon indicating copy to clipboard operation
core copied to clipboard
Published 3 weeks ago • verified publisher icon home-assistant

Add TechnoVE auto charge switch

Open Moustachauve opened this issue 1 year ago • 2 comments

Breaking change

Proposed change

This adds a first switch to the TechnoVE integration. It allows to enable or disable the auto-charge mode on the charging station.

The unit tests are built in a way that it will be easy to add more switch soon.

https://github.com/Moustachauve/pytechnove/releases/tag/v1.2.0

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/31131

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Moustachauve avatar Jan 30 '24 04:01 Moustachauve

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Jan 30 '24 05:01 home-assistant[bot]

I moved the dependency version bump to https://github.com/home-assistant/core/pull/109098.

Moustachauve avatar Jan 30 '24 06:01 Moustachauve

This should be ready for review

Moustachauve avatar Feb 13 '24 01:02 Moustachauve

Please rebase your branch as the snapshots might be outdated

Done. I have updated the snapshots.

Moustachauve avatar Feb 21 '24 02:02 Moustachauve