core icon indicating copy to clipboard operation
core copied to clipboard

Add nfandroidtv type checking and allow for strings to be passed to the image and icon data

Open miawgogo opened this issue 1 year ago • 3 comments

Proposed change

Adds some basic type checking to allow for strings to be passed as a icon or image into the service like other notify services. And also preserves the existing functionality that expects a dict

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #108647
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

miawgogo avatar Jan 22 '24 10:01 miawgogo

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (nfandroidtv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nfandroidtv can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign nfandroidtv Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Jan 22 '24 10:01 home-assistant[bot]

Thanks, can you please open a PR for the docs illustrating the way to do it both ways?

tkdrob avatar Jan 22 '24 11:01 tkdrob

yep, I'll write up the docs while running the tests at some point

miawgogo avatar Jan 22 '24 18:01 miawgogo

As requested in the review, please raise ServiceValidationError instead of logging. Please hit the "Ready for review"-button when done.

emontnemery avatar Apr 23 '24 07:04 emontnemery