core icon indicating copy to clipboard operation
core copied to clipboard

Add matrix message format 'notice' (m.notice)

Open oleg-fiksel opened this issue 1 year ago • 3 comments

This format is a so called "bot notice" is used for bot to post information into a room. This message will not cause notification on the members of the room.

This is very usefull for home-assistant tasks, which don't need user attention but just FYI messages.

Proposed change

Add new format m.notice for posting messages via Matrix Connector. m.notice or "bot notice" is commonly used in Matrix for posting information into chat rooms by bot. This will not trigger a notification in the room.

Type of change

  • [x] New feature (which adds functionality to an existing integration)

Additional information

  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

oleg-fiksel avatar Jan 14 '24 15:01 oleg-fiksel

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Jan 14 '24 15:01 home-assistant[bot]

Hey there @paarthshah, mind taking a look at this pull request as it has been labeled with an integration (matrix) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matrix can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matrix Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Jan 14 '24 15:01 home-assistant[bot]

Thanks for the fast response @PaarthShah ! I will address the open topics in the next days.

oleg-fiksel avatar Jan 15 '24 11:01 oleg-fiksel

:heavy_check_mark: created documentation PR

oleg-fiksel avatar Jan 16 '24 22:01 oleg-fiksel

Is there something pending from my side on this PR or are we just waiting for further review?

oleg-fiksel avatar Jan 24 '24 07:01 oleg-fiksel

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Mar 30 '24 16:03 github-actions[bot]

Hi! I didn't forget this PR. I will come back to this PR after a couple of months when I have more time.

oleg-fiksel avatar Apr 01 '24 08:04 oleg-fiksel

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar May 31 '24 09:05 github-actions[bot]

Sorry for the delay. I'm still planing to take this up again. Just need a bit more time.

oleg-fiksel avatar May 31 '24 09:05 oleg-fiksel

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Jul 30 '24 20:07 github-actions[bot]

I need more time to incorporate the changes happened in the meantime on the tests in my PR (rebase).

oleg-fiksel avatar Jul 31 '24 10:07 oleg-fiksel