core icon indicating copy to clipboard operation
core copied to clipboard

New Integration: WeatherFlow Cloud Data (Forecast)

Open jeeftor opened this issue 1 year ago • 4 comments
trafficstars

Breaking change

Proposed change

I wrote weatherflow integration which is a local only integration that receives weather data via UDP. Tempest Weatherflow also provides a Cloud/REST API. @briis developed a HACS module called WeatherFlow Forecast that utilizes the REST Api. In this PR I am working to bring functionality from that HACS module into core.

The HACS module provides both Weather Forecast and Cloud based sensor data. I decided to start with the Weather Forecast initially as this should bring the most functionality to HA as we already have a local module to get WeatherFlow data. Once this PR gets approved I'll work to bring in the cloud sensors (and/or) convince @briis to work on the PR himself :)

Hybrid vs Separate Integrations

I had a discussion with @joostlek about whether I should create a separate integration or extend the existing integration. I started down the path of extending the existing integration but the overall approach to these two integrations is different enough I think it serves to have it as a separate integration. One is entirely udp based while this one is entirely http based. I could also anticipate some users would want to run both at the same time

image

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

jeeftor avatar Dec 20 '23 20:12 jeeftor

Hey there @abmantis, @mkmer, mind taking a look at this pull request as it has been labeled with an integration (whirlpool) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of whirlpool can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign whirlpool Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Dec 20 '23 20:12 home-assistant[bot]

Lmao, tell me you use PyCharm refactoring without telling me you use PyCharm refactoring

joostlek avatar Dec 20 '23 20:12 joostlek

@home-assistant unassign whirlpool

abmantis avatar Dec 20 '23 21:12 abmantis

Already did :) @abmantis

joostlek avatar Dec 20 '23 21:12 joostlek