core icon indicating copy to clipboard operation
core copied to clipboard

Add Support for SleepIQ Foot Warmers

Open kbickar opened this issue 2 years ago • 5 comments

Proposed change

Adds a select entity to use a foot warmer (off/low/med/high) Adds a number entity to set the time the foot warmer will stay on for. The time is passed on with the call to change the select entity and does not modify the state of the bed.

I also considered adding a datetime entity for when the timer would expire that would be activated when the select is turned on but this only includes the basics

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [X] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/30484

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

kbickar avatar Dec 17 '23 22:12 kbickar

Hey there @mfugate1, mind taking a look at this pull request as it has been labeled with an integration (sleepiq) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sleepiq can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sleepiq Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Dec 17 '23 22:12 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Dec 18 '23 00:12 home-assistant[bot]

Please create a preliminary PR to update the dependency

There is no point in updating the dependency unless this PR gets approved...

kbickar avatar Dec 18 '23 01:12 kbickar

There is, keeping PRs small.

joostlek avatar Dec 18 '23 07:12 joostlek

There is, keeping PRs small.

I usually find it best to avoid merging a half working feature, but either way it's done now

kbickar avatar Dec 18 '23 15:12 kbickar

Can we also add the options in the strings.json and add a translation key to this entity?

joostlek avatar Dec 26 '23 20:12 joostlek