core icon indicating copy to clipboard operation
core copied to clipboard

Add sensors for Netatmo NIS and NACamDoorTag

Open yannc74 opened this issue 2 years ago • 5 comments

Proposed change

Add sensors for Netatmo products:

  1. Smart Indoor Siren
  2. Smart Door And Window Sensors

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

yannc74 avatar Dec 08 '23 12:12 yannc74

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Dec 08 '23 12:12 home-assistant[bot]

Hey there @cgtobi, mind taking a look at this pull request as it has been labeled with an integration (netatmo) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of netatmo can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign netatmo Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

home-assistant[bot] avatar Dec 08 '23 12:12 home-assistant[bot]

Thank you for contributing. I took a first glance at this and here are my concerns. First, especially the siren is a very momentary thing and IMO has more of an event character. Due to the polling limits the entity might only update itself every few minutes and would not reflect the actual state, which in this case might be more critical than with a temperature sensor for example. The same foes for the window sensor. The second thing that bothers me a bit is that neither of those sensors are backed by webhook events. As far as I recall those are available for both, at least for the siren. We should make use of that to improve responsiveness.

cgtobi avatar Dec 08 '23 12:12 cgtobi

Yes,

I confirm for webhook. an event is received when:

  • siren.monitoring or status is modified
  • opening.status , same

So, I'll check for this..

Thanks !

yannc74 avatar Dec 08 '23 13:12 yannc74

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Feb 08 '24 17:02 github-actions[bot]