core icon indicating copy to clipboard operation
core copied to clipboard

Add Epic Games Store integration

Open Quentame opened this issue 1 year ago • 3 comments
trafficstars

Proposed change

This PR adds 2 Epic Games Store calendars, for free and discount games.

It squashes 62 commits from Hacktoberfest 2022 old PR #81167, and took care of @joostlek, @nachonam and @epenet reviews.

I may eventually add price tracking for specific games in the future.

Screenshot:

Capture d’écran 2023-10-04 à 20 14 06

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • Link to brand pull request: https://github.com/home-assistant/brands/pull/3820
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/24798

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [x] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Quentame avatar Nov 29 '23 14:11 Quentame

@bramkragten: The new two-pane view from 2023.11 caused long label entity names not to be distinctive, not even a title or tooltip on mouse hover is present

image

One is a discount calendar, one is a free games calendar (mystery) 🔮

Compare to before 2023.11 in the PR description.

A possible solution could be using a shorter name as the integration page ? image

Also a solution, on the two-pane calendar page, open the more info dialog when clicking on the entity icon ?

Thanks

Quentame avatar Nov 29 '23 15:11 Quentame

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Dec 26 '23 14:12 home-assistant[bot]

@bramkragten: The new two-pane view from 2023.11 caused long label entity names not to be distinctive, not even a title or tooltip on mouse hover is present

I guess a tooltip/hover makes sense there yeah

bramkragten avatar Dec 28 '23 16:12 bramkragten

OMG, it happened 🎉

Original PR #81167 was oppened on october 2022 (but OK, it's not directly a home related integration).

Thanks everyone 😘

Quentame avatar Apr 22 '24 10:04 Quentame