Fix up Tuya Vacuum status values

[daniel-simpson]

Breaking change

Proposed change

Fixes status reporting when:

• uses DPCode.MODE to map correct status in fall-back situations
• returned value is "pause" => PAUSED
• a fault state is reported => ERROR

Type of change

• [ ] Dependency upgrade
• [x] Bugfix (non-breaking change which fixes an issue)
• [ ] New integration (thank you!)
• [ ] New feature (which adds functionality to an existing integration)
• [ ] Deprecation (breaking change to happen in the future)
• [ ] Breaking change (fix/feature causing existing functionality to break)
• [ ] Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #97836
• This PR is related to issue: #97836
• Link to documentation pull request: N/A, internals only

Checklist

• [x] The code change is tested and works locally.
• [x] Local tests pass. Your PR cannot be merged unless tests pass
• [x] There is no commented out code in this PR.
• [x] I have followed the development checklist
• [x] I have followed the perfect PR recommendations
• [x] The code has been formatted using Black (black --fast homeassistant tests)
• [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• [ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• [ ] The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• [ ] New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• [x] I have reviewed two other open pull requests in this repository.

[home-assistant[bot]]

Hey there @tuya, @zlinoliver, @frenck, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[daniel-simpson]

Note: the one failing linter is doing a code spellcheck, which is precisely what Tuya is getting wrong with their upstream API response 😅

Looks good from my end, will see if I can spot any easy to review PRs to help with the backlog 🤞

[home-assistant[bot]]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

[daniel-simpson]

Updated to minimal set of changes.

Any help with where to raise a ticket for Tuya support (Smart life app? github.com/tuya/tuya-home-assistant repo? Device manufacturer?) would be much appreciated. Didn't find anything useful on the forums. (Context: The "cleanning" string I'm seeing is appearing on iot.tuya.com, so it likely isn't any of the code in between their API and home assistant).

Thanks

[daniel-simpson]

Actually I think I have an idea on how to do this in a device-agnostic way. Will work on that next up, do some testing, and resubmit a bit later

[daniel-simpson]

Now fixes this issue in a device-agnostic way: if DPCode.STATUS doesn't map to anything meaningful, fall back to looking up (using the same map) via DPCode.MODE (smart, wall_follow, etc).

[daniel-simpson]

Rebased on latest dev, and tested working as expected. Please let me know if there is anything else I need to do, or anything you'd prefer was removed from this PR.

And thanks for all the great work across the whole Home Assistant codebase. Can only imagine what a huge job it is!

[daniel-simpson]

Going to split out into smaller changeset as this has completely stalled

[daniel-simpson]

Thought smaller PRs were preferred, and this one had stalled for weeks.

I'm aware things get busy, but is there something in particular you're waiting on from me here?

[frenck]

Please, have some patience. Thanks!

[github-actions[bot]]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

[github-actions[bot]]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

[daniel-simpson]

Never mind