core icon indicating copy to clipboard operation
core copied to clipboard

Fix utility meter reset without tarrifs

Open gibwar opened this issue 1 year ago • 4 comments

Proposed change

When using a utility_meter helper set up with a "Meter reset cycle" of "No cycle" it is impossible to properly reset the meter to 0 and utilize the "last reset" and "last period" attributes on the helper.

With these changes the service call can now directly reset a meter in such a configuration and the UI selector has been updated to include utility meters in the selection list.

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #96920
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

gibwar avatar Oct 27 '23 04:10 gibwar

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (utility_meter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of utility_meter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign utility_meter Removes the current integration label and assignees on the pull request, add the integration domain after the command.

home-assistant[bot] avatar Oct 27 '23 04:10 home-assistant[bot]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Dec 31 '23 14:12 github-actions[bot]

Rebased on to the latest dev

gibwar avatar Jan 02 '24 00:01 gibwar

Applied requested changes and updated to the latest dev build.

gibwar avatar Feb 08 '24 04:02 gibwar

Looking forward to this merge. I have a convoluted setup of sensors and automations trying to work around the current utility meter behaviour!

pmannk avatar Feb 22 '24 10:02 pmannk

Anything more I need to do to get this merged (hopefully before 2024.3)? It looks like it's ready to merge but I don't have permission to do so. I see the following:

This branch has no conflicts with the base branch Only those with write access to this repository can merge pull requests.

gibwar avatar Feb 27 '24 00:02 gibwar

It awaits at least 1 more core developer review

dgomes avatar Feb 27 '24 00:02 dgomes

Fantastic! I wanted to make sure I wasn't missing something on my end. Thanks!

gibwar avatar Feb 27 '24 05:02 gibwar