core
core copied to clipboard
Add integration lamarzocco
Breaking change
Proposed change
Start bringing the custom_component lamarzocco to core. The integration allows to interact with La Marzocco coffee machines, through a mix of cloud calls, local API calls, websocket calls and Bluetooth (like the official app does).
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/29436
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] I have followed the perfect PR recommendations
- [x] The code has been formatted using Black (
black --fast homeassistant tests
) - [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [x] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [x] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest
. - [x] New or updated dependencies have been added to
requirements_all.txt
.
Updated by runningpython3 -m script.gen_requirements_all
. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc
.
To help with the load of incoming pull requests:
- [x] I have reviewed two other open pull requests in this repository.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
Please make sure CI is passing. Currently, there is a dependency conflict
I can't trigger that by myself, or can I?
that's weird. The mypy in my local venv seems to want a different annotation on that import... Will look into that.
This PR is already big don't add any new features to it like [add options flow](https://github.com/home-assistant/core/pull/102291/commits/b3cb2ebc6826cee6c0d683cc4b66f348357de8b1)
These features can be added in a follow up PR. Please only fix the CI
This PR is already big don't add any new features to it like
[add options flow](https://github.com/home-assistant/core/pull/102291/commits/b3cb2ebc6826cee6c0d683cc4b66f348357de8b1)
These features can be added in a follow up PR. Please only fix the CI
Fair point. That conflict is new though... -.-
CI should be passing now.
@edenhaus apologies for the ping, but the bot somehow didn't trigger a request when I converted the draft back to "ready to review" and I also don't understand which requested changes are not addressed yet (except the CI which I can't trigger by myself...)
through a mix of cloud calls, local API calls, websocket calls and Bluetooth (like the official app does).
This sounds messy... Please explain in more detail which protocol is used and when.
Is the communication device dependent? Meaning one device model will only communicated via Bluetooth, another only via cloud?
It is a bit messy unfortunately, but it's what their official app does... Some commands will be sent through Bluetooth (if available, otherwise through the cloud), some commands are cloud only. Some data can be retrieved through local HTTP calls (or through the cloud) and some data is only available on the WebSocket, to which the machine pushes updates...
I'm supporting all of those to avoid using the cloud whenever possible and replicating the official app as closely as possible.
Why are you deleting tags and releases in your third-party library?
Why are you deleting tags and releases in your third-party library?
Because I pushed something by mistake which was very broken.
I removed all the Bluetooth parts for now, will add in a separate PR.