brands icon indicating copy to clipboard operation
brands copied to clipboard

Add dreo integration brand

Open w-xtao opened this issue 11 months ago • 6 comments

Proposed change

Type of change

  • [x] Add a new logo or icon for a new core integration
  • [ ] Add a missing icon or logo for an existing core integration
  • [ ] Add a new logo or icon for a custom integration (custom component)
  • [ ] Replace an existing icon or logo with a higher quality version
  • [ ] Replace an existing icon or logo after a branding change
  • [ ] Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request: https://github.com/home-assistant/core/pull/135107
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/36851
  • Link to integration documentation on our website:
  • Link to custom integration repository:

Checklist

  • [x] The added/replaced image(s) are PNG
  • [x] Icon image size is 256x256px (icon.png)
  • [x] hDPI icon image size is 512x512px for ([email protected])
  • [x] Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • [x] hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

w-xtao avatar Jan 09 '25 03:01 w-xtao

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Jan 13 '25 12:01 home-assistant[bot]

Hi there @w-xtao 👋

To ensure the logo looks good in Home Assistant, can we remove some of the white/empty space on the top/bottom of the logo versions?

../Frenck @frenck Yes,I 've changed the icon and log picture

w-xtao avatar Jan 14 '25 08:01 w-xtao

Hi @fredck

Thank you for your feedback! I have removed the blank space at the top and bottom of the logo and optimized its display. Please let me know if it meets the requirements. If there are any further suggestions, feel free to let me know!

Best regards,
w-xtao

w-xtao avatar Jan 14 '25 14:01 w-xtao

I have removed the blank space at the top and bottom of the logo and optimized its display.

Sorry, but that isn't showing. Let me try to explain what I mean:

CleanShot 2025-01-14 at 15 51 26@2x

../Frenck

frenck avatar Jan 14 '25 14:01 frenck

Hi @frenck I've removed the white/empty of the logo. To maintain consistency with the logo font, I've changed the icon to black text on a transparent background. If there are still any issues, please feel free to let me know ,And is it convenient to speed up the review process? Thanks,

w-xtao avatar Jan 19 '25 05:01 w-xtao

And is it convenient to speed up the review process?

Have patience. There are almost 1000 Pull requests open in this organization, meaning you have to show some patience.

frenck avatar Jan 19 '25 18:01 frenck