brands icon indicating copy to clipboard operation
brands copied to clipboard

Adding icon/logo for hass-hjq custom integration.

Open XiaoMiku01 opened this issue 1 year ago • 2 comments

Proposed change

Adding icon/logo for hass-hjq custom integration.

Type of change

  • [ ] Add a new logo or icon for a new core integration
  • [ ] Add a missing icon or logo for an existing core integration
  • [x] Add a new logo or icon for a custom integration (custom component)
  • [ ] Replace an existing icon or logo with a higher quality version
  • [ ] Replace an existing icon or logo after a branding change
  • [ ] Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository: https://github.com/XiaoMiku01/hass-hjq

Checklist

  • [x] The added/replaced image(s) are PNG
  • [x] Icon image size is 256x256px (icon.png)
  • [x] hDPI icon image size is 512x512px for ([email protected])
  • [x] Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • [x] hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

XiaoMiku01 avatar Oct 22 '24 15:10 XiaoMiku01

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Oct 23 '24 20:10 home-assistant[bot]

I've changed the directory name, by the way, do I need to change the domain in manifest.json as well?

XiaoMiku01 avatar Oct 24 '24 01:10 XiaoMiku01

Yes, the domain of the manifest should match the directory names (in both the custom integration and this PR).

../Frenck

frenck avatar Oct 24 '24 06:10 frenck

all changed ! tks !

XiaoMiku01 avatar Oct 24 '24 06:10 XiaoMiku01