brands icon indicating copy to clipboard operation
brands copied to clipboard

Add dreo integration icons and logos

Open dreo-team opened this issue 1 year ago • 7 comments

Proposed change

Add dreo integration icons and logos

Type of change

  • [x] Add a new logo or icon for a new core integration
  • [ ] Add a missing icon or logo for an existing core integration
  • [ ] Add a new logo or icon for a custom integration (custom component)
  • [ ] Replace an existing icon or logo with a higher quality version
  • [ ] Replace an existing icon or logo after a branding change
  • [ ] Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request: https://github.com/home-assistant/core/pull/119075
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/32869
  • Link to integration documentation on our website:
  • Link to custom integration repository:https://github.com/dreo-team/home-assistant-custom

Checklist

  • [x] The added/replaced image(s) are PNG
  • [x] Icon image size is 256x256px (icon.png)
  • [x] hDPI icon image size is 512x512px for ([email protected])
  • [ ] Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • [x] hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

dreo-team avatar May 22 '24 09:05 dreo-team

Hey home-assistant! Is it convenient to speed up the review process? Thanks, The Dreo Team

dreo-team avatar May 24 '24 01:05 dreo-team

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar May 24 '24 13:05 home-assistant[bot]

What to do next?

Resolve the conflict as pointed out in the review comment above.

../Frenck

frenck avatar May 27 '24 06:05 frenck

Can you tell me which PR conflicts? It is best to have a PR address. Thanks!

https://github.com/home-assistant/brands/pull/5487#pullrequestreview-2077019249

frenck avatar May 27 '24 06:05 frenck

There is not git conflict, my comment doesn't write or say that.

There is a link to a custom integration, which has a conflicting integration domain with the PR in the core repository, both use the dreo domain, which will cause conflicts for users.

☝️ There is a domain conflict.

Additionally, this PR links to a custom integration and a core integration. Which is odd, as brands are either for a core domain or a custom domain, not both.

../Frenck

frenck avatar May 27 '24 06:05 frenck

I'm sorry, I'm not sure how to make this more clear.

We are dealing with a language gap (considering you seem to be using a translation tool for this). I would advise you to see if you can find someone who can help with the translating so you can understand the issue and review comments better.

../Frenck

frenck avatar May 27 '24 07:05 frenck

Hello! How is the PR review going?

dreo-team avatar May 30 '24 01:05 dreo-team

Closing PR as the parent PR has been closed.

frenck avatar Aug 07 '24 09:08 frenck