brands icon indicating copy to clipboard operation
brands copied to clipboard

Add VSN Logos

Open kilimnik opened this issue 2 years ago • 3 comments

Proposed change

Type of change

  • [x] Add a new logo or icon for a new core integration
  • [ ] Add a missing icon or logo for an existing core integration
  • [ ] Add a new logo or icon for a custom integration (custom component)
  • [ ] Replace an existing icon or logo with a higher quality version
  • [ ] Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request: https://github.com/home-assistant/core/pull/78839
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/24193
  • Link to integration documentation on our website:

Checklist

  • [x] The added/replaced image(s) are PNG
  • [x] Icon image size is 256x256px (icon.png)
  • [x] hDPI icon image size is 512x512px for ([email protected])
  • [x] Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • [x] hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

kilimnik avatar Dec 29 '22 14:12 kilimnik

The linked hafas integration uses implenets a virtual vsn integration

kilimnik avatar Jan 03 '23 15:01 kilimnik

The linked hafas integration uses implenets a virtual vsn integration

An PR against core can only implement a single integration as a time. So, that would be incorrect/impossible.

../Frenck

frenck avatar Jan 03 '23 16:01 frenck

Just to clarify, if I understood that correctly. I am not allowed to add a virtual integration in the same pr as the integration is added in. So I have to wait until the base integration is merged and after that, I can make a new PR with the virtual integration added?

kilimnik avatar Jan 08 '23 15:01 kilimnik

Closing PR as the parent PR has been closed.

frenck avatar May 18 '24 11:05 frenck