brands icon indicating copy to clipboard operation
brands copied to clipboard

Add Hafas Logos

Open kilimnik opened this issue 3 years ago • 4 comments

Proposed change

I added the logos to the intergration Hafas aswell as the virtual integrations.

Type of change

  • [x] Add a new logo or icon for a new core integration
  • [ ] Add a missing icon or logo for an existing core integration
  • [ ] Add a new logo or icon for a custom integration (custom component)
  • [ ] Replace an existing icon or logo with a higher quality version
  • [ ] Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request: https://github.com/home-assistant/core/pull/78839
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/24193
  • Link to integration documentation on our website: https://www.home-assistant.io/integrations/hafas/

Checklist

  • [x] The added/replaced image(s) are PNG
  • [x] Icon image size is 256x256px (icon.png)
  • [x] hDPI icon image size is 512x512px for ([email protected])
  • [x] Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • [x] hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

kilimnik avatar Dec 23 '22 22:12 kilimnik

I split the pr into multiple prs.

kilimnik avatar Dec 29 '22 14:12 kilimnik

It wasn't clear to me, what the difference between both folders is, as I did not find any documentation for that. I am happy to move it though

kilimnik avatar Jan 03 '23 15:01 kilimnik

It wasn't clear to me, what the difference between both folders is

The core_brands folder is for matching image assets from brand domains in Home Assistant. The core_integrations folder is for matching image assets for integrations domains in Home Assistant.

So, in this case, it depends if you are adding a brand or integration. And if there is a brand added, there should be at least 2 integration available that is categorized under that brand domain (otherwise a branding domain wouldn't be needed).

../Frenck

frenck avatar Jan 03 '23 16:01 frenck

Thanks for clarifying, I did change the directory

kilimnik avatar Jan 08 '23 15:01 kilimnik

Closing PR as the parent PR has been closed.

frenck avatar May 18 '24 11:05 frenck