brands icon indicating copy to clipboard operation
brands copied to clipboard

Add Sonos brand

Open VIKTORVAV99 opened this issue 3 years ago • 1 comments

Proposed change

Adds Sonos to brands and symlinks the integration.

Type of change

  • [ ] Add a new logo or icon for a new core integration
  • [ ] Add a missing icon or logo for an existing core integration
  • [ ] Add a new logo or icon for a custom integration (custom component)
  • [ ] Replace an existing icon or logo with a higher quality version
  • [ ] Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request: https://github.com/home-assistant/core/pull/80293
  • Link to documentation pull request:
  • Link to integration documentation on our website:

Checklist

  • [ ] The added/replaced image(s) are PNG
  • [ ] Icon image size is 256x256px (icon.png)
  • [ ] hDPI icon image size is 512x512px for ([email protected])
  • [ ] Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • [ ] hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

VIKTORVAV99 avatar Oct 13 '22 21:10 VIKTORVAV99

I haven't really used symlinks before so I'm not sure why it's failing. Any insight into the issue would be appreciated.

VIKTORVAV99 avatar Oct 13 '22 21:10 VIKTORVAV99

It looks like you created a textfile in the sonos directory with the content ../core_brands/sonos instead of a link.

The directory brands/core_intergrations/sonos needs to be deleted. Then you can replace the deleted directory with a symlink to the new brands directory.

Executing ln -s ../core_brands/sonos sonos while in the /brands/core_integrations directory seems to work (at least when running ls -al it show the link the same as for others).

mvdwetering avatar Oct 19 '22 20:10 mvdwetering

It looks like you created a textfile in the sonos directory with the content ../core_brands/sonos instead of a link.

The directory brands/core_intergrations/sonos needs to be deleted. Then you can replace the deleted directory with a symlink to the new brands directory.

Executing ln -s ../core_brands/sonos sonos while in the /brands/core_integrations directory seems to work (at least when running ls -al it show the link the same as for others).

Thanks! I'll try it later today! 👍🏻

VIKTORVAV99 avatar Oct 20 '22 06:10 VIKTORVAV99

Closing this PR as the parent PR has been closed.

frenck avatar Oct 25 '22 15:10 frenck