brands
brands copied to clipboard
Add kdeconnect integration
Proposed change
This commit adds icons and logos for the new KDE Connect integration I developed.
Type of change
- [x] Add a new logo or icon for a new core integration
- [ ] Add a missing icon or logo for an existing core integration
- [ ] Add a new logo or icon for a custom integration (custom component)
- [ ] I've opened up a PR for my custom integration on the Home Assistant Python wheels repository
- [ ] Replace an existing icon or logo with a higher quality version
- [ ] Removing an icon or logo
Additional information
- This PR fixes or closes issue: fixes #
- Link to code base pull request: https://github.com/home-assistant/core/pull/67703
- Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/21914
- Link to integration documentation on our website:
Checklist
- [x] The added/replaced image(s) are PNG
- [x] Icon image size is 256x256px (
icon.png
) - [x] hDPI icon image size is 512x512px for (
[email protected]
) - [x] Logo image size has min 128px, but max 256px, on the shortest side (
logo.png
) - [x] hDPI logo image size has min 256px, but max 512px, on the shortest side (
[email protected]
)
Hi @freundTech,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Could you explain, why you would expect the KDE logo instead of the KDE Connect logo? The logo I submitted is the Logo used by KDE Connect on Android, iOS and PC.
KDE Connect, while under the KDE umbrella, is a separate project, that doesn't depend on the KDE desktop environment and can also be used by for example gnome users.
In addition, my integration doesn't only allow pairing to PCs but also to phones running KDE Connect, which would leave desktop linux, and therefore everything KDE other than KDE Connect, out of the equation entirely.
I agree that it's better to use this KDE Connect logo instead of a generic KDE one, so this should be good to go. Btw, the logo usage seems to be inconsistent: the one used on android has no pinhole nor speaker slit.
I agree that it's better to use this KDE Connect logo instead of a generic KDE one, so this should be good to go.
Sorry, that is incorrect.
This brand repo carries branding of manufacturers, not products. We do allow product branding, in case the integration is grouped by a brand, however, that is not the case.
Thus, in this case, KDE Connect is provided by the KDE project. It even shows as such big on the website and is hosted under the KDE flag and domain.
It is comparible to many other manufacturers who have branding for specific product lines, or services.
I stand corrected, thanks @frenck! I'd really like to see kdeconnect supported, are you still interested in working on this, @freundTech?
@rytilahti There is a parent PR linked in the PR description.
@rytilahti I'm still interested in working on this, but don't have the time for it right now, so don't expect any progress in the near future. If someone else wants to pick up where I left of that's of course ok too.
Closing PR as the parent PR has been closed.