brands
brands copied to clipboard
added images for custom componente vartastorage
Proposed change
Type of change
- [ ] Add a new logo or icon for a new core integration
- [ ] Add a missing icon or logo for an existing core integration
- [ X] Add a new logo or icon for a custom integration (custom component)
- [ ] I've opened up a PR for my custom integration on the Home Assistant Python wheels repository
- [ ] Replace an existing icon or logo with a higher quality version
- [ ] Removing an icon or logo
Additional information
- This PR fixes or closes issue: fixes #
- Link to code base pull request:
- https://github.com/Vip0r/brands/tree/master/custom_integrations/vartastorage
- Link to documentation pull request:
- Link to integration documentation on our website:
Checklist
- [ X ] The added/replaced image(s) are PNG
- [ X ] Icon image size is 256x256px (
icon.png
) - [ X ] hDPI icon image size is 512x512px for (
[email protected]
) - [ X ] Logo image size has min 128px, but max 256px, on the shortest side (
logo.png
) - [ X ] hDPI logo image size has min 256px, but max 512px, on the shortest side (
[email protected]
)
I cannot find the public repository providing this custom integration, could you point me to it?
I cannot find the public repository providing this custom integration, could you point me to it?
The integration is not yet published. I plan for an pull request in the next days (currently i am testing on my own dev-environment). Is it a requirement that the integration already is published before adding the images?
The integration is not yet published.
I cannot review or approve this PR without a actual integration 🤷
The integration is not yet published.
I cannot review or approve this PR without a actual integration 🤷
Okay, got it. Can we let this change in the current state ? I plan to publish the integration within next days and would post this link afterwards here
Hi frenck,
as discussed i now made the PR for the documentation: https://github.com/home-assistant/home-assistant.io/pull/21112
and also created the PR for the integration itself: https://github.com/home-assistant/core/pull/63736
Updated target folder. Sorry for the inconvenience - its my first PR :/
as the folder for the integration itself need to be changed to varta_storage i assume i need to change this for the brand images as well.
Hey frenck, updated now the folder name according to the new domain name you recommended within the PR for the new integration
Hi there, i plan to publish an integration in the HACS until my PR to the core repo will be approved
Can you please merge this to provide the commuity the VARTA Brand?
Please adjust your PR in that case, it should not go into core_integrations but custom_integrations: Contains images for custom integrations (custom components).
done @tjorim : moved files from core_integrations to custom_integrations
Closing PR as the linked parent PR has been closed.