architecture icon indicating copy to clipboard operation
architecture copied to clipboard

Add Edge Cleaning to Vacuum

Open JXGA opened this issue 6 years ago • 6 comments
trafficstars

Context

The current Vacuum core entity service includes many common modes for smart-home Vacuums, but it's missing 'edge clean'. This is similar in application to the currently implemented 'spot clean', but at the moment would need to be implemented to multiple vacuum integrations individually.

Proposal

Adding 'edge clean' mode to the core service, meaning less redundant coding required per vacuum integration. Proposed code is in this PR; https://github.com/home-assistant/home-assistant/pull/25483

Consequences

Easier integration for edge cleaning for multiple brands (I have Eufy Robovac, on the community it seems Ecovac has a similar requirement, I'm sure there will be plenty of other brands to integrate with HA). I cannot see addition causing breaking changes as nothing is to be removed.

Thanks for your time.

JXGA avatar Jul 31 '19 13:07 JXGA

Could you help do some legwork to see if other brands support this functionality? I think that's one of the key factors we'd want to understand -- is this just 1 or 2 brands, or is it prevalent.

andrewsayre avatar Aug 01 '19 17:08 andrewsayre

From a quick look, it seems that most Eufy models support Edge mode. As each of the different Eufy machines use a different API, it means redundant coding to get edge mode added to the integration.

In addition, it looks as though the Eufy machines are similar to iLife Vacuums and DeeBot (maybe just rebranded with different top covers) - all of which would require a different API to use them with HA.

The DeeBot vac had previous requests on the HA community forum for Edge mode.

As there are more and more vacs being added to market, I think this addition adds value to the HA Vacuum service.

JXGA avatar Aug 05 '19 14:08 JXGA

Is this something specific to one manufacturer and not all? Neato does not offer edge cleaning but does offer a wide variety of other settings. For this we introduced a custom cleaning service call that allows the user to specify the different parameters that only neato robots take.

dshokouhi avatar Aug 19 '19 20:08 dshokouhi

Hello, I just got the integration working with Ecovacs and can start the N97s model and send it to charge. I set it up in the hope I could automate the edge cleaning command (specificity to start it and automate stopping it after a set time so it will do just 2 circuits). Is there a way to do this? I found the following on GitHub, but I'm not sure if/how I can use them: CleaningCommand State Request Response type auto automatic cleaning program type border edge cleaning program type spot spot cleaning program type singleroom cleaning a single room type stop bot at full stop speed standard regular fan speed (suction) speed strong high fan speed (suction)

Donostio avatar Jul 03 '21 20:07 Donostio

This sounds like a common feature in robotic lawn mowers which currently often use the vacuum domain due to the conceptual similarity.

thomasloven avatar Jul 04 '21 17:07 thomasloven

Ecovacs vacuums can be automated to use the edge cleaning mode by using this integration as a replacement for the ecovacs default integration: https://github.com/Ligio/ozmo

You do have to set it up to send a custom command (screenshot attached). image

When you do this the status of the vacuum currently shows "Error". I'm hoping to find a fix for this....

clayauld avatar Sep 13 '21 06:09 clayauld

This architecture issue is old, stale, and possibly obsolete. Things changed a lot over the years. Additionally, we have been moving to discussions for these architectural discussions.

For that reason, I'm going to close this issue.

../Frenck

frenck avatar May 11 '23 14:05 frenck