android icon indicating copy to clipboard operation
android copied to clipboard
verified publisher icon home-assistant

Enable edge-to-edge support for BaseActivity

Open TimoPtr opened this issue 8 months ago • 1 comments

Summary

This PR enable edge-edge support at the BaseActivity level. It removes the indivual calls that were made in some other Base classes like for configure widget.

Checklist

  • [ ] New or updated tests have been added to cover the changes following the testing guidelines.
  • [x] The code follows the project's code style and best_practices.
  • [x] The changes have been thoroughly tested, and edge cases have been considered.
  • [x] Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Any other notes

Part of https://github.com/home-assistant/android/issues/5328

TimoPtr avatar Jun 03 '25 12:06 TimoPtr

Should the PR's status be changed to draft while we wait for the WebView changes, as those also extend BaseActivity?

jpelgrom avatar Jun 03 '25 12:06 jpelgrom

I believe it's related to strict mode rather than the code change in this PR, but the barcode scanner immediately crashes for me.

jpelgrom avatar Jul 17 '25 05:07 jpelgrom

I believe it's related to strict mode rather than the code change in this PR, but the barcode scanner immediately crashes for me.

Indeed it crashes for me too on main. The issue seems to come from wrong context being used.

TimoPtr avatar Jul 17 '25 06:07 TimoPtr

Tracked here https://github.com/journeyapps/zxing-android-embedded/issues/762 but it seems that the lib is not maintained anymore. I'm going to ignore the issue for now.

TimoPtr avatar Jul 17 '25 06:07 TimoPtr