addons icon indicating copy to clipboard operation
addons copied to clipboard

silabs-flasher: Drop firmwares and update to latest universal flasher

Open agners opened this issue 7 months ago • 4 comments

The firmware files bundled with this add-on are outdated at this point. Since firmware updates for Home Assistant Yellow and ZBT-1 are handled by Home Assistant Core anways, let's simply drop the bundled firmwares.

While at it, update the add-on to use the latest universal flasher and base images.

Summary by CodeRabbit

  • New Features
    • Updated to require users to provide a firmware URL for flashing Silicon Labs radios.
  • Bug Fixes
    • Simplified firmware flashing process by removing automatic device detection and bundled firmware files.
  • Documentation
    • Updated README and changelog to clarify that official firmware updates for Home Assistant Yellow and ZBT-1 are now managed by Home Assistant Core.
    • Improved formatting and usage instructions in documentation.
  • Chores
    • Upgraded base Alpine Linux and tool versions for improved compatibility and security.

agners avatar May 09 '25 10:05 agners

📝 Walkthrough

Walkthrough

The changes update the Silicon Labs Flasher add-on to remove built-in firmware management for Home Assistant Yellow and ZBT-1 devices, making firmware updates reliant on a user-supplied URL. The configuration now requires a firmware URL, related scripts are simplified, and dependencies are updated to newer versions.

Changes

File(s) Change Summary
silabs_flasher/CHANGELOG.md Added entry for version 0.4.0: firmware updates for Yellow and ZBT-1 now managed by Home Assistant Core; removed bundled firmware; upgraded Alpine Linux to 3.21; updated universal-silabs-flasher to 0.0.30.
silabs_flasher/README.md Updated to clarify add-on's new purpose, emphasizing user-supplied firmware URL; added notes about firmware management by Home Assistant Core; improved formatting and documentation clarity.
silabs_flasher/build.yaml Updated base Python Docker images from 3.11-alpine3.19 to 3.13-alpine3.21; incremented universal-silabs-flasher version from 0.0.25 to 0.0.30.
silabs_flasher/config.yaml Changed firmware_url from optional to required string in the configuration schema.
silabs_flasher/rootfs/etc/s6-overlay/scripts/universal-silabs-flasher-up Simplified script: removed device-type-based firmware selection, deleted unused variables and functions, now always requires and uses user-supplied firmware URL for flashing.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AddOn
    participant FirmwareURL
    participant Device

    User->>AddOn: Provides configuration with firmware_url
    AddOn->>FirmwareURL: Downloads firmware from URL
    FirmwareURL-->>AddOn: Firmware file
    AddOn->>Device: Flashes firmware to device
    AddOn->>User: Logs success or failure

[!TIP]

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 09 '25 10:05 coderabbitai[bot]

Let me double check if we rely on the flasher addon anywhere in Core to install Zigbee firmware. If we do, this will have to be restricted to 2025.6.0 and newer.

puddly avatar May 09 '25 13:05 puddly

Unfortunately, we do: https://github.com/home-assistant/core/blob/763f2bcfcc697a59802c873078cd3750141013e1/homeassistant/components/homeassistant_hardware/firmware_config_flow.py#L261-L271

This will have to be replaced to use the firmware flasher in Core directly.

puddly avatar May 09 '25 13:05 puddly

Unfortunately, we do: https://github.com/home-assistant/core/blob/763f2bcfcc697a59802c873078cd3750141013e1/homeassistant/components/homeassistant_hardware/firmware_config_flow.py#L261-L271

This will have to be replaced to use the firmware flasher in Core directly.

Hm I see. I guess I could also retain the firmware this time around :thinking: . But probably cleaner to remove that reference and then restrict the add-on to the Core release where it is fixed or newer.

agners avatar May 12 '25 17:05 agners