addons
addons copied to clipboard

Published 20 hours ago •

Reame
Issues

Parenthesis in friendly name inserts wrong entity_name on Search entity (file editor)

Open maweki opened this issue 2 years ago • 13 comments

trafficstars

Describe the issue you are experiencing

If you have an entity with a friendly_name that includes parenthesis (in my case "On Air (Maria)") and you select that entity in the "Search entity" field and select it, you get the first paranthesized word instead of the last.

I wasn't able to find the actual source code of the file editor webapp. Maybe the link to there could be a tad more obvious. So I wasn't able to look at the source and provide a PR. But my suggestion is (1) use the last capture group instead of the first or (2) add the correct entity_name as a data-attribute to the selectable value and pull from there.

What type of installation are you running?

Home Assistant OS

Which operating system are you running on?

Home Assistant Operating System

Which add-on are you reporting an issue with?

File editor

What is the version of the add-on?

5.4.2

Steps to reproduce the issue

Have entity with parenthesized text in friendly_name
Try to insert it via "Search entity" selector

System Health information

Derzeit sind keine Reparaturen verfügbar

Anything in the Supervisor logs that might be useful for us?

No response

Anything in the add-on logs that might be useful for us?

No response

Additional information

No response

Dec 03 '22 21:12 maweki

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Jan 02 '23 22:01 github-actions[bot]

It's not stale. It's untriaged.

Jan 03 '23 06:01 maweki

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Feb 02 '23 07:02 github-actions[bot]

It's not stale. If anybody could give me a pointer on where that code is, it would have been fixed by now.

Feb 02 '23 07:02 maweki

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Mar 04 '23 09:03 github-actions[bot]

This issue is still not stale. Can somebody please point me to where the code is and I'll fix it myself.

Mar 04 '23 09:03 maweki

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Apr 03 '23 10:04 github-actions[bot]

This issue is still not stale. Can somebody please point me to where the code is and I'll fix it myself.

Apr 03 '23 10:04 maweki

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

May 03 '23 12:05 github-actions[bot]

still not stale

May 03 '23 12:05 maweki

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Jun 02 '23 13:06 github-actions[bot]

Is really nobody reading any of these tickets here?

Jun 05 '23 06:06 maweki

This issue is still not stale. Can somebody please point me to where the code is and I'll fix it myself.

The configuration webapp is installed from PyPI, the project is at https://github.com/danielperna84/hass-configurator.

I guess many developers moved to the Visual Studio Code add-on, so there is not as much attention to this add-on anymore.

Jun 05 '23 22:06 agners