Letsencrypt add-on does not allow propagation seconds for ovh

[akram]

Describe the issue you are experiencing

Letsencrypt add-on does not allow propagation seconds for ovh even if the value is passed to the configuration. The problem is that certbot sets this value to 30 seconds for the ovh-dns implementation and this is way too short. Increasing the value with propagation-seconds is not taken into account.

s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
cont-init: info: running /etc/cont-init.d/file-structure.sh
cont-init: info: /etc/cont-init.d/file-structure.sh exited 0
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
services-up: info: copying legacy longrun lets-encrypt (no readiness notification)
s6-rc: info: service legacy-services successfully started
[13:47:56] INFO: Selected DNS Provider: dns-ovh
[13:47:56] INFO: Use propagation seconds: 180
Saving debug log to /var/log/letsencrypt/letsencrypt.log
Requesting a certificate for my-host.my-domain.ovh
Waiting 30 seconds for DNS changes to propagate
Certbot failed to authenticate some domains (authenticator: dns-ovh). The Certificate Authority reported these problems:
  Domain: my-host.my-domain.ovh
  Type:   dns
  Detail: DNS problem: NXDOMAIN looking up TXT for _acme-challenge.my-host.my-domain.ovh - check that a DNS record exists for this domain
Hint: The Certificate Authority failed to verify the DNS TXT records created by --dns-ovh. Ensure the above domains are hosted by this DNS provider, or try increasing --dns-ovh-propagation-seconds (currently 30 seconds).

What type of installation are you running?

Home Assistant OS

Which operating system are you running on?

Home Assistant Operating System

Which add-on are you reporting an issue with?

Let's Encrypt

What is the version of the add-on?

4.12.7

Steps to reproduce the issue

1. Setup a dns based ovh
2. try to update
3. it fails with the following message

s6-rc: info: service s6rc-oneshot-runner: starting
s6-rc: info: service s6rc-oneshot-runner successfully started
s6-rc: info: service fix-attrs: starting
s6-rc: info: service fix-attrs successfully started
s6-rc: info: service legacy-cont-init: starting
cont-init: info: running /etc/cont-init.d/file-structure.sh
cont-init: info: /etc/cont-init.d/file-structure.sh exited 0
s6-rc: info: service legacy-cont-init successfully started
s6-rc: info: service legacy-services: starting
services-up: info: copying legacy longrun lets-encrypt (no readiness notification)
s6-rc: info: service legacy-services successfully started
[13:47:56] INFO: Selected DNS Provider: dns-ovh
[13:47:56] INFO: Use propagation seconds: 180
Saving debug log to /var/log/letsencrypt/letsencrypt.log
Requesting a certificate for my-host.my-domain.ovh
Waiting 30 seconds for DNS changes to propagate
Certbot failed to authenticate some domains (authenticator: dns-ovh). The Certificate Authority reported these problems:
  Domain: my-host.my-domain.ovh
  Type:   dns
  Detail: DNS problem: NXDOMAIN looking up TXT for _acme-challenge.my-host.my-domain.ovh - check that a DNS record exists for this domain
Hint: The Certificate Authority failed to verify the DNS TXT records created by --dns-ovh. Ensure the above domains are hosted by this DNS provider, or try increasing --dns-ovh-propagation-seconds (currently 30 seconds).

Anything in the Supervisor logs that might be useful for us?

No response

Anything in the add-on logs that might be useful for us?

No response

Additional information

No response

[ludeeus]

Why open an issue after opening a PR to add it?

[akram]

Hi @ludeeus , this is for tracking purposes. Maybe the fix will be rejected or the PR will not be sufficient. Also, users generally search issuers first.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.