addons icon indicating copy to clipboard operation
addons copied to clipboard

Add/Fix Azure section

Open icyfire0573 opened this issue 2 years ago • 3 comments

I went through this and couldn't get this to work without looking at error messages first problem was it didn't say that i need the azure_config and what that did. I corrected that (row 165) second problem was a style issue? or me trying to fix this based on experience. I'd have tweaked more but ran out of time.

icyfire0573 avatar Aug 09 '22 10:08 icyfire0573

Hi @icyfire0573,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant avatar Aug 09 '22 10:08 homeassistant

I've got #2605 in the queue to fix the issue with the nonexistent azure_creds parameter (correct: azure_config). If you've got azure_creds in the addon configuration it should error and refuse to accept when you try to save it.

backerman avatar Aug 22 '22 19:08 backerman

Yea I think we just need to fix the doc bug in #2605. I get that you're trying to make the steps more explicit but to be honest I don't want that in this doc. I think the doc for this addon should basically just link to the certbot plugin doc.

The problem is that we (developers in this repo) don't own this setup process. It can change at any time because Microsoft or the developers of that plugin made a change. And then now the addon needs to be updated because the doc is out of date.

Better to simply link to instructions maintained by the folks who actually maintain the plugin. At least for the things you have to do outside of our control (like making an application on azure).

mdegat01 avatar Aug 29 '22 15:08 mdegat01