addons icon indicating copy to clipboard operation
addons copied to clipboard

Published 20 hours ago • verified publisher icon home-assistant

Support CNAME records

Open ocalvo opened this issue 3 years ago • 2 comments
trafficstars

Follow up to #2410

ocalvo avatar Jul 03 '22 22:07 ocalvo

ping, do not close

ocalvo avatar Aug 01 '22 17:08 ocalvo

@ocalvo I'm fine with this but you never answered my question on the last PR here. Basically just want to know if this note in the DNSMasq documation on cnames is something we should worry about:

Provide an alias for a "local" DNS name. Note that this only works for targets which are names from DHCP or /etc/hosts. Give host "bert" another name, bertrand cname=bertand,bert

The emphasis on "only" here suggests it is something DNSMasq users are frequently tripped up by. Should we note the same in the documentation of this option?

Added the same note in the DOCS.

ocalvo avatar Aug 01 '22 17:08 ocalvo

Keep alive

ocalvo avatar Aug 23 '22 23:08 ocalvo

@frenck this has been open for months and closed at least 2 times becuase time passes. Can we add a rule that if the PR has a review and comments that the bot does not closes the PR?

ocalvo avatar Aug 23 '22 23:08 ocalvo

Keep alive

ocalvo avatar Aug 25 '22 20:08 ocalvo

Need to bump the version in config.yaml to 1.5.0, you only bumped the changelog. Then I can merge it. Sorry for the delay.

Done

ocalvo avatar Aug 29 '22 16:08 ocalvo

Thanks @ocalvo 👍

mdegat01 avatar Aug 29 '22 16:08 mdegat01