CAP_project
CAP_project copied to clipboard
homalg-project
Added monoidal structure to AdditiveClosure
@mohamed-barakat
This is my first pull request! I have implemented the monoidality of the AdditiveClosure. I have not done anything about rigidity.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.82%. Comparing base (
0cfc327) to head (25dc3c9). Report is 2 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1689 +/- ##
==========================================
+ Coverage 82.72% 82.82% +0.09%
==========================================
Files 559 559
Lines 77165 77309 +144
==========================================
+ Hits 63837 64028 +191
+ Misses 13328 13281 -47
| Flag | Coverage Δ | |
|---|---|---|
| ActionsForCAP | 64.04% <ø> (ø) |
|
| AttributeCategoryForCAP | 90.45% <ø> (ø) |
|
| CAP | 86.29% <ø> (+0.04%) |
:arrow_up: |
| CartesianCategories | 89.36% <ø> (ø) |
|
| CompilerForCAP | 95.86% <ø> (ø) |
|
| ComplexesAndFilteredObjectsForCAP | 73.55% <ø> (ø) |
|
| FreydCategoriesForCAP | 82.55% <100.00%> (+0.57%) |
:arrow_up: |
| GeneralizedMorphismsForCAP | 61.76% <ø> (ø) |
|
| GradedModulePresentationsForCAP | 44.62% <ø> (ø) |
|
| GroupRepresentationsForCAP | 71.92% <ø> (ø) |
|
| HomologicalAlgebraForCAP | 73.21% <ø> (ø) |
|
| InternalExteriorAlgebraForCAP | 93.09% <ø> (ø) |
|
| LinearAlgebraForCAP | 66.54% <ø> (ø) |
|
| ModulePresentationsForCAP | 69.88% <ø> (ø) |
|
| ModulesOverLocalRingsForCAP | 90.70% <ø> (ø) |
|
| MonoidalCategories | 89.70% <ø> (ø) |
|
| ToricSheaves | 21.79% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@damian-delafuente: The code-coverage just reached 70% because the examples for the associators are somehow missing, maybe you didn't save them.
Is the math for this written down somewhere? It might be nice to add it (or a reference to it) to the documentation.
I doubt it. The implementation simply reflects the additivity of the tensor product, that all.
@mohamed-barakat Does this PR require a mathematical review from me?
No, thank you, no mathematical review required, just the technical review you already did :)
I just noticed that the new tests in this PR are not compatible with Julia. @mohamed-barakat Is this something you would like to fix together with @damian-delafuente?
We will meet on Monday and take care of it. Could you please provide more details if you have time?
Could you please provide more details if you have time?
There aren't many details to provide: make gen; make test in CAP_project.jl/FreydCategoriesForCAP fails since this PR, for example due to differences in ring names.