CAP_project icon indicating copy to clipboard operation
CAP_project copied to clipboard

installed derivations for Abelian categories

Open mohamed-barakat opened this issue 2 years ago • 4 comments

  • IsomorphismFromKernelOfCokernelToImageObject
  • IsomorphismFromCoimageToCokernelOfKernel

mohamed-barakat avatar Dec 19 '22 20:12 mohamed-barakat

This is a resurrection of https://github.com/homalg-project/CAP_project/pull/1196.

mohamed-barakat avatar Dec 19 '22 20:12 mohamed-barakat

Codecov Report

Base: 76.75% // Head: 76.75% // No change to project coverage :thumbsup:

Coverage data is based on head (95ca8cb) compared to base (95ca8cb). Patch has no changes to coverable lines.

:exclamation: Current head 95ca8cb differs from pull request most recent head 8c109da. Consider uploading reports for the commit 8c109da to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1211   +/-   ##
=======================================
  Coverage   76.75%   76.75%           
=======================================
  Files         494      494           
  Lines       60462    60462           
=======================================
  Hits        46405    46405           
  Misses      14057    14057           
Flag Coverage Δ
ActionsForCAP 41.23% <0.00%> (ø)
AttributeCategoryForCAP 86.34% <0.00%> (ø)
CAP 81.85% <0.00%> (ø)
CartesianCategories 92.69% <0.00%> (ø)
CompilerForCAP 95.12% <0.00%> (ø)
ComplexesAndFilteredObjectsForCAP 73.17% <0.00%> (ø)
DeductiveSystemForCAP 25.48% <0.00%> (ø)
FreydCategoriesForCAP 80.75% <0.00%> (ø)
GeneralizedMorphismsForCAP 62.47% <0.00%> (ø)
GradedModulePresentationsForCAP 44.57% <0.00%> (ø)
GroupRepresentationsForCAP 49.72% <0.00%> (ø)
HomologicalAlgebraForCAP 73.21% <0.00%> (ø)
InternalExteriorAlgebraForCAP 40.24% <0.00%> (ø)
LinearAlgebraForCAP 66.27% <0.00%> (ø)
ModulePresentationsForCAP 68.93% <0.00%> (ø)
ModulesOverLocalRingsForCAP 90.02% <0.00%> (ø)
MonoidalCategories 87.00% <0.00%> (ø)
ToricSheaves 21.79% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Dec 19 '22 21:12 codecov[bot]

As just discussed verbally, I do not expect the current implementation to give something conceptionally different. And indeed, what this PR does simply corresponds to the rule UniqueRightDivide( HomalgIdentityMatrix( ... ), UniqueRightDivide( A, B ) ) ) = UniqueRightDivide( B, A ). Of course having this rule on a categorical level might be a good thing, but I think it would be interesting to first look at the suggestion above, which does something conceptionally different.

zickgraf avatar Jan 11 '23 12:01 zickgraf

I agree

mohamed-barakat avatar Jan 11 '23 21:01 mohamed-barakat