a-shell keeps forgetting custom bookmarked locations

[NightMarekApps]

hi! since the last update the app has forgotten my bookmarked locations multiple times. i dont know what causes it

[holzschu]

What I've done in the last update is check that bookmarks are still valid at startup, and remove the ones that aren't. This was to avoid the "cd ~bookmark" that was followed by "no such file or directory". It shouldn't remove a bookmark that is still valid.

[NightMarekApps]

i did some testing to see when that happens. it happens everytime i restart my device. bookmarks disappear and i get this jump: [bookmark] not found

[NightMarekApps]

i restarted the device before using cd command above happens both on ipad and iphone (both beta) since the latest a-shell update

[holzschu]

Yes, restarting the device was making the bookmarks invalid, so that "cd ~bookmarkName" was returning "No such file or directory". You're saying that it was working with jump before, even though it was not working with cd?

[NightMarekApps]

i only ever used jump and it always worked for me. since last update this happens after restart

[holzschu]

So the problem was with cd, not with the bookmarks. Thank you very much. I'm going to change that.

[NightMarekApps]

Thank you. i dont quite understand how cd is the problem here my workflow is this: pick folder, bookmark it once with custom shortname using bookmark command. then always go to that folder using the jump command. now after restart it says jump: shortname not found

im happy to do some further testing if you need

[holzschu]

cd was checking both isReadableFileAtPath and changeCurrentDirectoryPath for each directory, jump was just trying changeCurrentDirectoryPath. It seems that after a reboot, isReadableFileAtPath becomes false for a bookmarked directory, even though changeCurrentDirectoryPath still works. That's weird and unexpected, but I'll adapt the code.

[NightMarekApps]

Thank you. I did some more testing though and after bookmarking locations, i ran showmarks to show my newly created bookmarks, and they are listed there

i then rebooted and ran showmarks again, and these bookmarks are gone. they disappear after restart

[holzschu]

That makes sense: that's what I wrote the code for, to avoid the issue with "cd ~bookmark: permission denied".

[NightMarekApps]

im sorry that is complicated for me, does that mean your fix will fix it? or that it forgets them by design :)

[holzschu]

Yes, the new fix will remove the previous fix, and you will get back the previous behaviour with version 1.9.7. As a bonus, people who use "cd ~bookmark" instead of "jump bookmark" will also enjoy bookmarks that remain valid after a reboot.

[NightMarekApps]

Thank you so much for all this and for quick responses!

[AlbertBaubleDeem]

When can we expect a new release with the fix?

[holzschu]

I believe that fix was released months ago, around version 1.9.7. Do you still observe a problematic behaviour?

[SirLukeSchande]

I just got the behaviour the first time. I'm not aware of a recent update. So could this be due to the latest iOS update?