camunda-bpm-taskpool icon indicating copy to clipboard operation
camunda-bpm-taskpool copied to clipboard
verified publisher icon holunda-io

consider Optional for nullable query results

Open jangalinski opened this issue 3 years ago • 4 comments

While implementing #566 I noticed, that TaskForIdQuery uses a nullable Task? result.

This also applies to TaskWithDataEntriesForIdQuery.

I would prefer using java Optional here and use the axon ResponseTypes.optionalOf(...) for query execution.

jangalinski avatar May 16 '22 08:05 jangalinski

This is a good idea. Optional in query results was introduced after I designed the API (at least as far as I know) - so yes. Optional seems nice from the Java point of view but is even more complex to use out of Kotlin.... Let's go for it

zambrovski avatar May 17 '22 09:05 zambrovski

Breaking change - should be at least in a minor release...

zambrovski avatar May 17 '22 09:05 zambrovski

Should we do this for 3.3.0 while adding the potentially breaking changes to the view-api data classes?

jangalinski avatar Jun 24 '22 12:06 jangalinski

No ... moved to 3.4.0

jangalinski avatar Jun 24 '22 12:06 jangalinski

Moved to 3.6.0

zambrovski avatar Dec 01 '22 14:12 zambrovski