Karl Holub

Moving to https://github.com/agentcooper/react-pdf-highlighter/issues/180

@agentcooper Could you provide feedback on code/approach, or let us know if you are not interested in integrating these features? Thanks!

The bug doesn't reside there, but the middle highlight rects are being filtered out in `getClientRects`, where the `isClientRectInsidePageRect` check is failing. In the below example, the middle highlights have...

Although I don't understand its implications, this behavior seems to be driven by `textLayerMode: 2` for the `PDFViewer`, which was introduced in https://github.com/agentcooper/react-pdf-highlighter/pull/170. When I switch the mode between 1...

@OscarBC Thanks for digging in! It's hard to tell from your screen grabs if you did this in all your testing, but you have to click "Add Highlight" to trigger...

Yep, I noticed the same. I'm not sure that's the way to go here, however, as the text selection felt degraded with mode=1 (less margin on the side to start...

For any application taking variable inputs (in the searched text or pattern, both in my case), it's essential to be able to give up and move on for "bad" inputs...

It's understandable if CRA is no longer being maintained. It's disappointing & unprofessional that maintainers haven't come forward to announce deprecation or intent to continue developing v5. There may be...

Could you include the code you were running? If you include a reproducible example I'd like to fix this up.

Thank you! I will take a crack at this in the coming days.