Karl Holub

Results 20 comments of Karl Holub

I'm really not familiar with this project's framework / development stack, but running ```sh npm install deasync ``` from project root solved this problem for me. I'm not sure why...

Also, it looks like we have no tests on `mmulStrassen` for inputs > 512x512, which means this algo is functionally untested.

1. This is just a deprecation warning. Nothing is currently broken. Rolling back to `react-scripts@4` is unnecessary at this point and likely not a good idea. 2. The PR linked...

@sbaggott I'm not a maintainer, just an interested party. It does seem as though this is impacting a large number of users; Even more so if it's crashing the dev...

@OscarBC I did a checkout on your branch and unfortunately it seems #180 is not fixed, at least on my system. ```sh MacBook-Pro:react-pdf-highlighter kholub$ git status On branch fix/v5.4.0_fix Your...

My team has been hacking on this from the parent component, using `window.PDFViewer`; beyond being kind of gross in using a global intended for debug, I believe it's the cause...

Our team opened a PR here: https://github.com/agentcooper/react-pdf-highlighter/pull/185. We package the fork, which includes some other QOL goodies, on NPM: https://www.npmjs.com/package/@darian-lp/react-pdf-highlighter It's our goal to move off the fork once the...

See discussion in https://github.com/agentcooper/react-pdf-highlighter/issues/176 for adding this to API.

My team has noticed improvements in the text layer (fewer spacing issues) in master with pdf.js 2.11, coming from 2.8. Any ETA for next release? We can try to help...

Awesome! Text selection quality is improved (the attached example would always be missing spaces because every word was wrapped in a span). I believe the improvement is due to [this...