chroxy icon indicating copy to clipboard operation
chroxy copied to clipboard

Support Chromium and configurable Chrome Path

Open holsee opened this issue 5 years ago • 2 comments

Short term goal would be to support configuration of the path (as per other configuration through environment variables).

This function would need to be modified: https://github.com/holsee/chroxy/blob/a1997bd12c26dbd62c6653405af8c99b7fb01f87/lib/chroxy/chrome_server.ex#L347-L354

From early testing, Chromium was fully compatible.

holsee avatar May 03 '19 11:05 holsee

FWIW, I'm able to set a different browser path with:

config :chroxy, Chroxy.ChromeServer, chrome_path: System.get_env("CHROXY_CHROME_PATH")

in my own app's config.exs when using Chroxy as a library.

Is the implementation of this feature just adding the above line to Chroxy's config.exs?

eahanson avatar Jul 09 '19 00:07 eahanson

Looks like I have implemented this and forgot: https://github.com/holsee/chroxy/blob/a1997bd12c26dbd62c6653405af8c99b7fb01f87/lib/chroxy/chrome_server.ex#L132-L137

I would suggest we document this in the README or we add that ENV VAR as something baked in that will take the first precedence.

Documentation should be fine.

holsee avatar Jul 18 '19 17:07 holsee