param icon indicating copy to clipboard operation
param copied to clipboard

Add .rx.set method

Open philippjfr opened this issue 1 year ago • 4 comments

Implements https://github.com/holoviz/param/issues/956

philippjfr avatar Jul 28 '24 08:07 philippjfr

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 88.12%. Comparing base (b95d476) to head (778a64d). :warning: Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #957   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files           9        9           
  Lines        4857     4859    +2     
=======================================
+ Hits         4280     4282    +2     
  Misses        577      577           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 28 '24 08:07 codecov[bot]

Are people ok with the linguistic ambiguity between "set" as a collection of items and "set" as "assign"? I find .rx.assign to more obviously indicate the latter meaning, but it's maybe less guessable? I.e. if I think about what I want to do to assign a value, "set" is indeed the word I think of, but then when I encounter .rx.set, I'm not sure which of the two meanings it would be. Happy with whatever other people agree on...

jbednar avatar Feb 17 '25 19:02 jbednar

FWIW I'm fine with the naming of .rx.set (.rx.pipe(set | list | ...) being I believe the correct way to cast).

maximlt avatar Feb 17 '25 23:02 maximlt

I like set because its the term used in React Docs.

MarcSkovMadsen avatar Feb 18 '25 03:02 MarcSkovMadsen

I'm ok with rx.set(). How about you @philippjfr?

maximlt avatar Sep 22 '25 21:09 maximlt

+1 on keeping .set

philippjfr avatar Sep 23 '25 09:09 philippjfr

Unrelated test failures.

maximlt avatar Sep 23 '25 18:09 maximlt