param icon indicating copy to clipboard operation
param copied to clipboard

ListSelector restricted to list type objects

Open maximlt opened this issue 4 years ago • 1 comments

Fixes #527

I chose to raise a ValueError when the type is not a list since raising ValueError seems to be what param does in this case. The tests used to catch TypeErrors in some occasions because param was trying to iterate over non iterables.

maximlt avatar Sep 20 '21 23:09 maximlt

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f87fa8c). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #531   +/-   ##
=========================================
  Coverage          ?   82.12%           
=========================================
  Files             ?        4           
  Lines             ?     2954           
  Branches          ?        0           
=========================================
  Hits              ?     2426           
  Misses            ?      528           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f87fa8c...5e725e6. Read the comment docs.

codecov-commenter avatar Oct 08 '21 20:10 codecov-commenter

We need to be consistent about ValueError and TypeError but in this case this is more consistent because it matches what param.List raises when given the wrong type.

philippjfr avatar Jan 16 '23 16:01 philippjfr