param icon indicating copy to clipboard operation
param copied to clipboard

unwatch should not log a warning when it fails

Open maximlt opened this issue 1 year ago • 1 comments

Reviewing Marc's docstring update work, I saw that unwatch apparently logs a warning if it fails at removing a watcher, there has to be a better way, e.g. raising a LookupError.

    def unwatch(self_, watcher):
        """Remove the given Watcher object (from `watch` or `watch_values`) from this object's list."""
        try:
            self_._register_watcher('remove', watcher, what=watcher.what)
        except Exception:
            self_.warning(f'No such watcher {str(watcher)} to remove.')

maximlt avatar Jan 03 '25 14:01 maximlt

I don't know of any reason it wasn't always an exception, but maybe someone else remembers.

jbednar avatar Jan 03 '25 19:01 jbednar