panel icon indicating copy to clipboard operation
panel copied to clipboard

Add DatetimeSlider widget

Open thuydotm opened this issue 1 year ago • 4 comments

This MR adds DatetimeSlider widget, which is mentioned in https://github.com/holoviz/panel/issues/1972. The code is mainly based on Bokeh DateSlider model and the existing Panel DateSlider widget. Huge thanks to @hoxbro for your support!

TODO:

  • [x] add tests
  • [x] add reference notebook

thuydotm avatar Oct 08 '24 10:10 thuydotm

I’m think about the unit for step param? Looking at the existing datetime select widget, DatetimeRangeSlider, the unit is in ms. But we only display the information up to seconds with format "%d %b %Y %H:%M:%S", should it be second instead of ms?

thuydotm avatar Oct 08 '24 11:10 thuydotm

pre-commit.ci autofix

thuydotm avatar Oct 08 '24 13:10 thuydotm

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.23%. Comparing base (4e146af) to head (7398483). Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7374      +/-   ##
==========================================
+ Coverage   81.42%   82.23%   +0.81%     
==========================================
  Files         337      338       +1     
  Lines       50514    50598      +84     
==========================================
+ Hits        41131    41611     +480     
+ Misses       9383     8987     -396     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 11 '24 11:10 codecov[bot]

@hoxbro thanks for reviewing! I've pushed the changes as suggested.

thuydotm avatar Oct 11 '24 13:10 thuydotm

Thanks @thuydotm!!

philippjfr avatar Oct 31 '24 09:10 philippjfr

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Sep 09 '25 18:09 github-actions[bot]