panel icon indicating copy to clipboard operation
panel copied to clipboard

Start adding full calendar

Open ahuang11 opened this issue 1 year ago • 2 comments

Closes https://github.com/holoviz/panel/issues/6953

Focusing only on the view options for now

Not sure how to handle interactions https://fullcalendar.io/docs/date-clicking-selecting

  • [ ] docs
  • [ ] tests
  • [ ] fix re-rendering
import panel as pn

pn.extension()

cal = pn.widgets.Calendar(sizing_mode="stretch_both")

cal.add_event("2024-10-01 12:00")
cal.show()
image

ahuang11 avatar Oct 03 '24 23:10 ahuang11

This pull request has been mentioned on HoloViz Discourse. There might be relevant details there:

https://discourse.holoviz.org/t/how-to-use-jscomponent-with-fullcalendar/8306/11

holovizbot avatar Oct 04 '24 01:10 holovizbot

Codecov Report

Attention: Patch coverage is 85.51136% with 51 lines in your changes missing coverage. Please review.

Project coverage is 82.27%. Comparing base (26c2e7a) to head (f5c8482). Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
panel/tests/ui/widgets/test_calendar.py 72.72% 48 Missing :warning:
panel/widgets/calendar.py 98.01% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7356      +/-   ##
==========================================
+ Coverage   82.25%   82.27%   +0.01%     
==========================================
  Files         337      340       +3     
  Lines       50678    51030     +352     
==========================================
+ Hits        41685    41983     +298     
- Misses       8993     9047      +54     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 04 '24 01:10 codecov[bot]

Can this be compiled with the plugins dynamically loaded @philippjfr

ahuang11 avatar Oct 21 '24 15:10 ahuang11

If loading plugins dynamically means loading modules dynamically then yes. See https://dmitripavlutin.com/ecmascript-modules-dynamic-import/.

MarcSkovMadsen avatar Oct 21 '24 17:10 MarcSkovMadsen

This is ready for review, besides the compilation part, which I don't really know what to do.

Optimally this would be in a separate package like panel-mermaid.

My gut is saying that this should be part of core Panel since "it's just a calendar" (can't really articulate it very well). To me, it's like Tabulator, and I honestly think panes like VTK & Vizzu should be split out. If not, I suppose this could be a good test case for using https://github.com/philippjfr/panel-copier-template and preparing the community template pages

ahuang11 avatar Oct 25 '24 21:10 ahuang11

This is ready for review, besides the compilation part, which I don't really know what to do.

Optimally this would be in a separate package like panel-mermaid.

My gut is saying that this should be part of core Panel since "it's just a calendar" (can't really articulate it very well). To me, it's like Tabulator, and I honestly think panes like VTK & Vizzu should be split out. If not, I suppose this could be a good test case for using https://github.com/philippjfr/panel-copier-template and preparing the community template pages

Agree that calendar functionality should be in core. In terms of widgets, a calendar is standard in many libraries, and it seems likely that this will be used often.

Coderambling avatar Nov 13 '24 08:11 Coderambling

This is now on https://panel-extensions.github.io/panel-full-calendar/

ahuang11 avatar Jan 09 '25 17:01 ahuang11

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Sep 09 '25 17:09 github-actions[bot]