panel icon indicating copy to clipboard operation
panel copied to clipboard

Set Tabulator to render into explicit popup container

Open philippjfr opened this issue 1 year ago • 4 comments

Not entirely happy with this as the editor isn't aligned quite right but I played with all the options and couldn't find one that produced the correct result.

Fixes https://github.com/holoviz/panel/issues/7295

philippjfr avatar Sep 19 '24 13:09 philippjfr

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 87.37%. Comparing base (977e801) to head (d09c0cd). :warning: Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7299      +/-   ##
==========================================
- Coverage   87.40%   87.37%   -0.04%     
==========================================
  Files         347      347              
  Lines       53618    53618              
==========================================
- Hits        46867    46850      -17     
- Misses       6751     6768      +17     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 19 '24 13:09 codecov[bot]

Seeing this problem for one of my examples in the original issue: image

hoxbro avatar Sep 19 '24 14:09 hoxbro

Yep, seeing that too. Not sure what to do about it.

philippjfr avatar Sep 19 '24 15:09 philippjfr

What about making this setting an option for now?

Or maybe document the behavior, as it can be enabled by the configuration directly: pn.widgets.Tabulator(... configuration={"popupContainer": True})

hoxbro avatar Sep 19 '24 15:09 hoxbro

So I'm leaning towards merging this as is now. It turns out the weird offset issue occurs only for the last column and in the meantime this PR also fixes:

https://github.com/holoviz/panel/issues/8096

and the coloring of the popup.

philippjfr avatar Sep 01 '25 11:09 philippjfr

Okay, fixed the offset issue by inserting an empty last column.

philippjfr avatar Sep 01 '25 12:09 philippjfr