panel icon indicating copy to clipboard operation
panel copied to clipboard

Front page app invisible text in dark mode

Open ahuang11 opened this issue 1 year ago • 5 comments

The widgets labels are invsible.

image

ahuang11 avatar Jun 05 '24 19:06 ahuang11

Thanks, until we have CSS styling of the plot we should disable dark mode again.

philippjfr avatar Jun 06 '24 23:06 philippjfr

Disable it only on that and similar pages I assume? Not actually disable it for the whole site?

Coderambling avatar Jun 21 '24 04:06 Coderambling

Disable it only on that and similar pages I assume? Not actually disable it for the whole site?

Yes for the whole site, a) there's no way to do it for specific pages and b) we will never catch all the pages where there might be an issue.

philippjfr avatar Jun 21 '24 11:06 philippjfr

Oof that seems quite a downgrade in terms of site functionality.

And it also doesn't look good in terms of perception.

I assume the invisible text issue occurs multiple times?

Users can probably fall back to a browser-level Dark Mode toggle, but still.

Is there a development path / PR to enable CSS for plots, so that there is a way back to re-enable dark mode at some point?

Should that happen at the Panel level, Bokeh level or somewhere else?

Coderambling avatar Jun 28 '24 02:06 Coderambling

Oof that seems quite a downgrade in terms of site functionality.

We had dark mode disabled for the longest time for this reason but recent versions of the pydata-sphinx-theme changed the APIs we used to disable it.

to enable CSS for plots, so that there is a way back to re-enable dark mode at some point?

Yes, it's being worked on in Bokeh 3.5 and 3.6.

philippjfr avatar Jun 28 '24 07:06 philippjfr