panel icon indicating copy to clipboard operation
panel copied to clipboard

Doc [DO NOT MERGE]: Add an announcement banner for Panel 1.4

Open maximlt opened this issue 2 years ago β€’ 2 comments

This PR is motivated by the goal of getting more GitHub stars, pushing on multiple fronts around a single event, that could be the Panel 1.4 release.

I built the small test site located in nbsite's repo to see how that would look like:

image

maximlt avatar Dec 08 '23 14:12 maximlt

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.74%. Comparing base (5578f98) to head (5bd5256). Report is 1233 commits behind head on main.

:exclamation: Current head 5bd5256 differs from pull request most recent head 1688b7a. Consider uploading reports for the commit 1688b7a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6013       +/-   ##
===========================================
- Coverage   82.75%   40.74%   -42.01%     
===========================================
  Files         239      291       +52     
  Lines       34507    43571     +9064     
===========================================
- Hits        28555    17754    -10801     
- Misses       5952    25817    +19865     
Flag Coverage Ξ”
ui-tests 40.74% <ΓΈ> (+2.62%) :arrow_up:
unitexamples-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 08 '23 15:12 codecov[bot]

@philippjfr if the blog post isn't ready when Panel 1.4 is released (which is often the case IIRC), I can update this PR to link to the Releases page.

maximlt avatar Feb 19 '24 12:02 maximlt

@philippjfr would you like this to be merged before releasing 1.4.0?

maximlt avatar Mar 24 '24 12:03 maximlt

@philippjfr would you like this to be merged before releasing 1.4.0?

Yes, I think so. How does it work? Will it always be there? Is it on all pages or just the home page? What's the process for removing it when "Panel 1.4 has just been released" is no longer true?

philippjfr avatar Mar 24 '24 12:03 philippjfr

How does it work? Will it always be there? Is it on all pages or just the home page? What's the process for removing it when "Panel 1.4 has just been released" is no longer true?

Good questions! :)

Yes, this banner is displayed on all pages.

Initially, I thought we'd keep the banner until a future release, before which we'd just remove the announcement key from conf.py. Looking at the theme docs again, they indicate you can point to an HTML file. So I've just tried that locally:

  • it fetches the banner content from the HTML file and displays it
  • if the file can't be fetched, no banner is displayed

So it seems we could use that to dynamically control whether the banner is displayed or not, and its content when displayed. I guess it'd be easier if the HTML file was served from another place (e.g. S3)?

I think I still prefer the simpler option of removing the announcement in a future release, perhaps in a month or so. But I'd be fine implementing the other approach too.


By the way, this is the current text:

Panel 1.4 has just been released! Checkout the release notes and support Panel by giving it a 🌟 on Github.

Feel free to enhance it, here's another suggestion:

Panel 1.4 released! Checkout the new features and support Panel by giving it a 🌟 on Github.

Interestingly, my initial intent with this PR was just to nudge people to add a star to Panel on GitHub. But I feel like announcing the new release also adds value, it can easily be missed if you're not watching closely our networks or Github.

maximlt avatar Mar 24 '24 12:03 maximlt

Thanks for the detailed answer. Since we are planning a 1.5 release pretty soon and there will be micro-releases we will have ample opportunity to adjust.

philippjfr avatar Mar 24 '24 13:03 philippjfr