panel icon indicating copy to clipboard operation
panel copied to clipboard

Upgrade GitHub Actions

Open cclauss opened this issue 1 year ago • 2 comments

cclauss avatar Sep 20 '22 15:09 cclauss

Looking good, thanks for the update! One issue we have with adding 3.10 to the test matrix is that it puts us (significantly) over the size of the GH Actions cache, which means that some environments will be evicted from the cache and will end up being rebuilt each time. I'm wondering whether we have a policy where we test the oldest Python and the two most recent Python versions (and therefore drop 3.8 from the matrix). @maximlt Do you have any opinions?

philippjfr avatar Sep 21 '22 17:09 philippjfr

Evens or odds also work: 3.6, 3.8, 3.10 or 3.7, 3.9, 3.11 (only two weeks away).

cclauss avatar Sep 21 '22 17:09 cclauss

I would rather drop 3.9 in that case, based on the numbers of downloads I see on PyPiStats there are way more downloads for 3.8 than 3.9. In practice I'm not sure I've ever seen on Panel an error introduced in the code that would break one of the intermediate supported versions. I find the tests useful though to spot errors in the ecosystem, which can happen on any version. That's why I suggest making that decision based on download counts.

And I would suggest running the complete matrix on scheduled runs, manual runs (triggered from GH UI) and dev releases.

maximlt avatar Sep 25 '22 17:09 maximlt

Codecov Report

Merging #3866 (b127424) into master (0278e47) will decrease coverage by 0.05%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3866      +/-   ##
==========================================
- Coverage   82.89%   82.84%   -0.06%     
==========================================
  Files         224      215       -9     
  Lines       32789    32385     -404     
==========================================
- Hits        27181    26828     -353     
+ Misses       5608     5557      -51     
Flag Coverage Δ
ui-tests 34.38% <ø> (+0.01%) :arrow_up:
unitexamples-tests 74.92% <ø> (-0.21%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/image.py 80.18% <0.00%> (-1.59%) :arrow_down:
panel/io/convert.py 29.57% <0.00%> (-1.41%) :arrow_down:
panel/io/resources.py 86.64% <0.00%> (-0.72%) :arrow_down:
panel/io/server.py 74.80% <0.00%> (-0.05%) :arrow_down:
panel/auth.py 39.20% <0.00%> (ø)
panel/io/pyodide.py 0.00% <0.00%> (ø)
panel/command/convert.py 64.28% <0.00%> (ø)
panel/tests/io/test_save.py 100.00% <0.00%> (ø)
panel/template/react/__init__.py 100.00% <0.00%> (ø)
panel/template/material/__init__.py 100.00% <0.00%> (ø)
... and 16 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 26 '22 08:09 codecov[bot]